fix: make dry-run fail-safe and non-mutating#96
Merged
Conversation
cstanislawski
force-pushed
the
fix/dry-run-safety
branch
from
July 15, 2026 15:40
2c65198 to
89ff16a
Compare
Owner
Author
|
Dry-run must never change the resource it is evaluating. Previously, only literal This change parses boolean values deliberately and fails on invalid input with a warning Event. Dry-run now performs no resource writes: no annotation conversion, restart patch, deletion, or recurring state update. Planning logs and Events remain, without requeueing the same occurrence. |
cstanislawski
marked this pull request as ready for review
July 15, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.