Update GCC CWE mappings#67
Closed
stevegrubb wants to merge 3 commits into
Closed
Conversation
This update adds most of the common GCC warnings with their CWE mapping. With this addition, this CSV file covers more than 95% of what you find in large scale wscanning.
kdudka
reviewed
Jun 6, 2022
Member
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Looks great. A few minor suggestions inline...
| "COMPILER_WARNING","warning[-Wreorder]","CWE-665" | ||
| "COMPILER_WARNING","warning[-Wrestrict]","CWE-9001" | ||
| "COMPILER_WARNING","warning[-Wreturn-local-addr]","CWE-562" | ||
| "COMPILER_WARNING","warning[-Wreturn-type]","CWE-393" |
Member
There was a problem hiding this comment.
CWE-393 seems accurate. Should we use it also for the MISSING_RETURN checker of Coverity, which overlaps with this?
Contributor
Author
There was a problem hiding this comment.
It appears that both are correct and related. 393->684->710. If you want to, we can use 393 for Coverity since it's more specific.
Contributor
Author
|
A new commit was added to this pull request. It updates a couple values based on the feedback. |
Contributor
Author
|
OK, the merge request was updated to map Wignored-qualifiers to 1164. |
Member
|
Thanks for the update! Merging now, will deploy it next week hopefully. |
kdudka
pushed a commit
that referenced
this pull request
Jun 9, 2022
kdudka
pushed a commit
that referenced
this pull request
Jun 9, 2022
kdudka
added a commit
that referenced
this pull request
Jun 9, 2022
... which is more specific than CWE-710 Closes: #67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds most of the common GCC warnings with their CWE mapping.
With this addition, this CSV file covers more than 95% of what you find
in large scale scanning.