Skip to content

Feature Add favicon #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lodewiges merged 4 commits into from
Dec 7, 2025
Merged

Feature Add favicon #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
569084c
Readd favicons
lodewiges Dec 6, 2025
876b71d
change favicon loading
lodewiges Dec 7, 2025
af360d9
readd mollie payment link
lodewiges Dec 7, 2025
934b543
Update app/views/layouts/application.html.erb
lodewiges Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

<%= csrf_meta_tags %>
<%= csp_meta_tag %>
<%= favicon_link_tag 'favicon.ico' %>

<%= stylesheet_link_tag "application", "data-turbo-track": "reload" %>
<%= javascript_include_tag "application", "data-turbo-track": "reload", defer: true %>
Expand Down
7 changes: 7 additions & 0 deletions app/views/users/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,13 @@
Om je saldo aan te vullen kan je zelf geld overmaken.
<% end %>
<%= "Dat kan naar #{Rails.application.config.x.company_iban} t.n.v. #{Rails.application.config.x.company_name}" %>
<%= 'onder vermelding van je naam en \'Inleg Zatladder\'.' %>

<% if Rails.application.config.x.mollie_api_key.present? %>
<%= link_to add_payments_path do %>
<%= 'Klik hier om je saldo over te maken via iDEAL ' %>
<% end %>
<% end %>
Comment on lines +126 to +132

@coderabbitai coderabbitai Bot Dec 7, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Payment instruction changes don't match PR title "Add favicon".

The PR is titled "Add favicon" and the AI summary mentions favicon changes to app/views/layouts/application.html.erb, but that file wasn't provided for review. The changes here add payment reference instructions and an iDEAL link, which seem unrelated to favicon functionality. Please verify that the correct files are included in this PR or update the title to reflect the actual scope.

Additionally, the ERB string literals on lines 126 and 130 are redundant—plain text works fine in ERB templates without wrapping strings in <%= %> tags. Line 130 also has a trailing space.

Apply this diff to simplify the markup:

-                  <%= 'onder vermelding van je naam en \'Inleg Zatladder\'.' %>
+                  onder vermelding van je naam en 'Inleg Zatladder'.

                   <% if Rails.application.config.x.mollie_api_key.present? %>
                     <%= link_to add_payments_path do %>
-                      <%= 'Klik hier om je saldo over te maken via iDEAL ' %>
+                      Klik hier om je saldo over te maken via iDEAL
                     <% end %>
                   <% end %>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<%= 'onder vermelding van je naam en \'Inleg Zatladder\'.' %>
<% if Rails.application.config.x.mollie_api_key.present? %>
<%= link_to add_payments_path do %>
<%= 'Klik hier om je saldo over te maken via iDEAL ' %>
<% end %>
<% end %>
onder vermelding van je naam en 'Inleg Zatladder'.
<% if Rails.application.config.x.mollie_api_key.present? %>
<%= link_to add_payments_path do %>
Klik hier om je saldo over te maken via iDEAL
<% end %>
<% end %>
🤖 Prompt for AI Agents 
In app/views/users/show.html.erb around lines 126 to 132, the changes add
payment instruction text and an iDEAL link that don't match the PR title "Add
favicon"—verify the PR scope and either update the title/description to include
payment changes or move these edits to a separate PR and include the actual
favicon changes (likely in app/views/layouts/application.html.erb). Also
simplify the ERB markup by replacing "<%= 'onder vermelding van je naam en
\'Inleg Zatladder\'.' %>" with plain text (no ERB tag), replace the link text
"<%= 'Klik hier om je saldo over te maken via iDEAL ' %>" with plain text
without the trailing space, and keep the conditional around link_to as-is;
ensure no extra whitespace remains.

</p>
<% end %>
</div>
Expand Down
Empty file removed public/apple-touch-icon-precomposed.png
View file
Open in desktop
Empty file.
Binary file modified public/apple-touch-icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/favicon.ico
View file
Open in desktop
Binary file not shown.
Binary file modified public/icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 1 addition & 3 deletions public/icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.