Skip to content

Conversation

@Portals
Copy link
Member

@Portals Portals commented Oct 21, 2025

Also limits new passwords to a maximum of 72 characters, due to bcrypt.

Copy link
Member

@GAsplund GAsplund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an acceptable regression as password resets are a thing.

LGTM

Copy link
Member

@Oscariremma Oscariremma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that we're updating the deps.
I don't think the password limit of "only" 72 chars will be a problem. The only thing i can think of is if she has an existing password of more than that. But in that case i guess they will just have to reset it...

@GAsplund
Copy link
Member

Good that we're updating the deps. I don't think the password limit of "only" 72 chars will be a problem. The only thing i can think of is if she has an existing password of more than that. But in that case i guess they will just have to reset it...

Yeah, that was my thinking as well. In theory, people could have >72 character passwords, and people who do will just have to reset their passwords to a <=72 character password.

@Portals
Copy link
Member Author

Portals commented Oct 22, 2025

Existing passwords and tokens with more than 72 characters will still work.

@Portals Portals merged commit 629e1ed into main Oct 22, 2025
2 checks passed
@Portals Portals deleted the chore-bump-dependencies branch October 22, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants