Skip to content

enzyme -> RTL: convert the NotificationTemplate screen suites #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cigamit merged 2 commits into from
Jun 18, 2026
Merged

enzyme -> RTL: convert the NotificationTemplate screen suites #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
717565d
enzyme -> RTL: convert the NotificationTemplate screen suites
blaipr Jun 16, 2026
9b34804
Address Copilot review comments
blaipr Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 28 additions & 73 deletions ...creens/NotificationTemplate/NotificationTemplateDetail/NotificationTemplateDetail.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import React from 'react';
import { act } from 'react-dom/test-utils';
import { screen } from '@testing-library/react';

import {
mountWithContexts,
waitForElement,
} from '../../../../testUtils/enzymeHelpers';
renderWithContexts,
assertDetail,
} from '../../../../testUtils/rtlContexts';
import NotificationTemplateDetail from './NotificationTemplateDetail';
import defaultMessages from '../shared/notification-template-default-messages.json';

Expand All @@ -23,28 +24,10 @@ const mockTemplate = {
organization: '/api/v2/organizations/1/',
},
summary_fields: {
organization: {
id: 1,
name: 'Default',
description: '',
},
created_by: {
id: 2,
username: 'test',
first_name: '',
last_name: '',
},
modified_by: {
id: 2,
username: 'test',
first_name: '',
last_name: '',
},
user_capabilities: {
edit: true,
delete: true,
copy: true,
},
organization: { id: 1, name: 'Default', description: '' },
created_by: { id: 2, username: 'test', first_name: '', last_name: '' },
modified_by: { id: 2, username: 'test', first_name: '', last_name: '' },
user_capabilities: { edit: true, delete: true, copy: true },
recent_notifications: [{ status: 'success' }],
},
created: '2021-06-16T18:52:23.811374Z',
Expand All @@ -68,61 +51,33 @@ const mockTemplate = {
};

describe('<NotificationTemplateDetail />', () => {
let wrapper;

afterEach(() => {
jest.clearAllMocks();
});

test('should render Details', async () => {
await act(async () => {
wrapper = mountWithContexts(
<NotificationTemplateDetail
template={mockTemplate}
defaultMessages={defaultMessages}
/>
);
});
await waitForElement(wrapper, 'ContentLoading', (el) => el.length === 0);
function assertDetail(label, value) {
expect(wrapper.find(`Detail[label="${label}"] dt`).text()).toBe(label);
expect(wrapper.find(`Detail[label="${label}"] dd`).text()).toBe(value);
}
const assertCommonDetails = async () => {
expect(await screen.findByText('Name')).toBeInTheDocument();
assertDetail('Name', mockTemplate.name);
assertDetail('Description', mockTemplate.description);
expect(
wrapper
.find('Detail[label="Email Options"]')
.containsAllMatchingElements([<li>Use SSL</li>, <li>Use TLS</li>])
).toEqual(true);
expect(
wrapper.find('Detail[label="Email Options"]').prop('helpText')
).toBeDefined();
// Email Options renders the SSL/TLS flags as list items
expect(screen.getByText('Use SSL')).toBeInTheDocument();
expect(screen.getByText('Use TLS')).toBeInTheDocument();
};

test('should render Details', async () => {
renderWithContexts(
<NotificationTemplateDetail
template={mockTemplate}
defaultMessages={defaultMessages}
/>
);
await assertCommonDetails();
});

test('should render Details when defaultMessages is missing', async () => {
await act(async () => {
wrapper = mountWithContexts(
<NotificationTemplateDetail
template={mockTemplate}
defaultMessages={null}
/>
);
});
await waitForElement(wrapper, 'ContentLoading', (el) => el.length === 0);
function assertDetail(label, value) {
expect(wrapper.find(`Detail[label="${label}"] dt`).text()).toBe(label);
expect(wrapper.find(`Detail[label="${label}"] dd`).text()).toBe(value);
}
assertDetail('Name', mockTemplate.name);
assertDetail('Description', mockTemplate.description);
expect(
wrapper
.find('Detail[label="Email Options"]')
.containsAllMatchingElements([<li>Use SSL</li>, <li>Use TLS</li>])
).toEqual(true);
expect(
wrapper.find('Detail[label="Email Options"]').prop('helpText')
).toBeDefined();
renderWithContexts(
<NotificationTemplateDetail template={mockTemplate} defaultMessages={null} />
);
await assertCommonDetails();
});
});
Loading