enzyme -> RTL: convert the Metrics screen suites - #439
Merged
Conversation
Migrate the Metrics screen's test suite off enzyme/mountWithContexts onto renderWithContexts (React Testing Library): LineChart and the Metrics page (instance/metric selects + chart fetch). Behaviour and assertions are preserved; interactions go through accessible roles and real user events.
blaipr
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the incremental Enzyme → React Testing Library migration by converting the Metrics screen test suites to RTL, switching from mountWithContexts to renderWithContexts and updating tests to use user-driven interactions and accessible queries.
Changes:
- Migrated
Metricsscreen tests from EnzymemountWithContexts+ direct prop calls to RTLrenderWithContexts+userEventinteractions. - Updated the
LineCharttest to assert against the rendered#chartcontainer and its help text content in a jsdom-friendly way.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| awx/ui/src/screens/Metrics/Metrics.test.js | Rewrites Metrics suite to RTL with helper-based select interactions and API-call assertions. |
| awx/ui/src/screens/Metrics/LineChart.test.js | Rewrites LineChart suite to RTL and validates #chart + help text rendering. |
| }); | ||
| // open the Instance select and pick "instance 1" | ||
| const instanceSelect = await openSelect('Instance-select'); | ||
| await user.click(within(instanceSelect).getByText('instance 1')); |
|
|
||
| // open the Metric select and pick "metric1" | ||
| const metricSelect = await openSelect('Metric-select'); | ||
| await user.click(within(metricSelect).getByText('metric1')); |
| ).toHaveLength(3); | ||
| const instanceSelect = await openSelect('Instance-select'); | ||
|
|
||
| const listbox = await within(instanceSelect).findByRole('listbox'); |
Contributor
Author
|
Thanks for the review. The option lookups now query from screen (the open listbox) instead of scoping to the select container, so the Popper-rendered options are found reliably. |
cigamit
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Converts the Metrics screen's test suite from enzyme to React Testing Library, continuing the incremental enzyme → RTL migration (one screen directory per PR).
Files migrated off
mountWithContexts/enzyme ontorenderWithContexts:LineChart— asserts the#chartcontainer renders and the help text lands in itMetrics— empty state, instance/metric Select interactions driving the exactMetricsAPI.readcall, and exclusion of receptor/execution nodes from the instance listInteractions now go through accessible roles (Selects scoped by their
ouiaId) and real user events. Behaviour and assertions are preserved.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
npm testfor the Metrics directory: 2 suites, 4 tests, all passing. ESLint clean. No production code changed — test-only.