enzyme -> RTL: convert the PromptDetail component suites - #459
Merged
Conversation
Migrate components/PromptDetail (PromptDetail and the per-resource detail variants: JobTemplate, WorkflowJobTemplate, InventorySource, Project) off enzyme/mountWithContexts onto renderWithContexts (React Testing Library). Prompt-override detail rows and credential/label chips are asserted via assertDetail/getByText; behaviour and assertions are preserved.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the enzyme → React Testing Library migration by converting the components/PromptDetail test suites to use renderWithContexts/RTL queries, focusing on the main PromptDetail suite and its per-resource detail variants.
Changes:
- Replaced enzyme
mountWithContextswrappers with RTLrenderWithContexts+screenqueries. - Standardized many label/value assertions using the shared
assertDetailhelper. - Updated “empty Detail” expectations to assert the label is absent (since
DetailreturnsnullwhenisEmpty).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| awx/ui/src/components/PromptDetail/PromptDetail.test.js | Migrates the main PromptDetail suite to RTL and updates prompt override section assertions. |
| awx/ui/src/components/PromptDetail/PromptJobTemplateDetail.test.js | Migrates Job Template prompt detail tests to RTL; adds link/content assertions for chips and sparkline links. |
| awx/ui/src/components/PromptDetail/PromptWFJobTemplateDetail.test.js | Migrates Workflow Job Template detail tests to RTL; updates activity/labels empty-row assertions. |
| awx/ui/src/components/PromptDetail/PromptInventorySourceDetail.test.js | Migrates Inventory Source detail tests to RTL; updates chips/options assertions and “Deleted” expectations. |
| awx/ui/src/components/PromptDetail/PromptProjectDetail.test.js | Migrates Project detail tests to RTL; replaces enzyme selectors with assertDetail/text assertions. |
Comments suppressed due to low confidence (1)
awx/ui/src/components/PromptDetail/PromptJobTemplateDetail.test.js:149
- This test overwrites
summary_fieldswith only{ labels: { results: [] } }, which drops othersummary_fieldskeys and can change unrelated rendering. Spread the originalsummary_fieldsand override onlylabels.
resource={{
...mockJT,
summary_fields: {
labels: {
results: [],
},
},
Comment on lines
100
to
104
| test('should render "Deleted" details', () => { | ||
| delete mockJT.summary_fields.inventory; | ||
| delete mockJT.summary_fields.organization; | ||
| delete mockJT.summary_fields.project; | ||
|
|
Comment on lines
115
to
120
| @@ -139,12 +120,11 @@ describe('PromptJobTemplateDetail', () => { | |||
| }} | |||
Comment on lines
129
to
134
| @@ -154,14 +134,11 @@ describe('PromptJobTemplateDetail', () => { | |||
| }} | |||
Comment on lines
+96
to
+97
| // Variables uses react-ace (empty under jsdom); assert the surrounding label | ||
| expect(screen.getByText('Variables')).toBeInTheDocument(); |
Comment on lines
55
to
60
| @@ -74,12 +60,12 @@ describe('PromptWFJobTemplateDetail', () => { | |||
| }} | |||
Comment on lines
+121
to
+122
| // No launchConfig prompt data + no overrides -> no "Prompted Values" section | ||
| expect(screen.queryByRole('heading', { level: 2 })).toBeNull(); |
Comment on lines
+170
to
+172
| expect( | ||
| screen.getByRole('heading', { level: 2 }) | ||
| ).toHaveTextContent('Prompted Values'); |
Comment on lines
+87
to
+88
| // Variables uses react-ace (empty under jsdom); assert the surrounding label | ||
| expect(screen.getByText('Variables')).toBeInTheDocument(); |
Comment on lines
+186
to
+187
| // Variables uses react-ace (empty under jsdom); assert the surrounding label | ||
| expect(screen.getByText('Variables')).toBeInTheDocument(); |
Comment on lines
57
to
+62
| test('should render "Deleted" details', () => { | ||
| delete mockProject.summary_fields.organization; | ||
| wrapper = mountWithContexts( | ||
| <PromptProjectDetail resource={mockProject} />, | ||
| { | ||
| context: { config }, | ||
| } | ||
| ); | ||
| assertDetail(wrapper, 'Organization', 'Deleted'); | ||
| renderWithContexts(<PromptProjectDetail resource={mockProject} />, { | ||
| context: { config }, | ||
| }); | ||
| assertDetail('Organization', 'Deleted'); |
Mock the CodeEditor leaf to assert the rendered extra_vars/source_vars YAML; clone shared mocks before deleting fields; spread summary_fields when overriding a single key; query the Prompted Values heading by accessible name; restore the Inventory File row assertion.
Contributor
Author
|
Thanks for the review. Pushed a commit: mock the CodeEditor leaf to assert the rendered extra_vars and source_vars YAML, clone the shared mocks before deleting fields, spread summary_fields when overriding a single key, query the Prompted Values heading by its accessible name, and restore the Inventory File row assertion. |
cigamit
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Converts the PromptDetail component test suite (
components/PromptDetail) from enzyme to React Testing Library, continuing the enzyme → RTL migration (components, one directory per PR).Files migrated off
mountWithContexts/enzyme ontorenderWithContexts:PromptDetailand the per-resource detail variants —PromptJobTemplateDetail,PromptWFJobTemplateDetail,PromptInventorySourceDetail,PromptProjectDetail.Prompt-override detail rows and credential/label chips are asserted via
assertDetail/getByText; emptyDetailrows (which rendernull) are asserted as absent. Behaviour and assertions are preserved.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
npm testforcomponents/PromptDetail: 5 suites, 20 tests, all passing. ESLint clean (--no-ignore). No production code changed — test-only. (Redundant mount-only "renders successfully" tests were folded into the detail-render tests since RTL renders fresh per test — no coverage dropped.)