enzyme -> RTL: convert the LaunchButton component suites - #469
Merged
Conversation
Migrate components/LaunchButton (LaunchButton and ReLaunchDropDown) off enzyme/mountWithContexts onto renderWithContexts (React Testing Library). Launch/relaunch are driven through the real button + dropdown items and asserted via the launch API calls and resulting navigation; behaviour and assertions are preserved.
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the LaunchButton component test suite from Enzyme (mountWithContexts) to React Testing Library (renderWithContexts), continuing the incremental enzyme → RTL conversion of UI component tests while preserving existing behavior assertions.
Changes:
- Converted
LaunchButton.test.jsto drive launch/relaunch flows via real user interactions and assert API calls +historynavigation via RTL (screen,userEvent,waitFor). - Converted
ReLaunchDropDown.test.jsto RTL interactions over the PatternFly dropdown and menu items, asserting relaunch callbacks. - Fixed the previously duplicated relaunch test name so both inventory-sync and project-sync cases run distinctly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| awx/ui/src/components/LaunchButton/ReLaunchDropDown.test.js | Rewrites dropdown interaction tests from Enzyme to RTL using role-based queries and userEvent. |
| awx/ui/src/components/LaunchButton/LaunchButton.test.js | Rewrites launch/relaunch + error-modal tests from Enzyme to RTL, adding stable accessible names for test-driven buttons and waiting for async navigation. |
cigamit
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Converts the LaunchButton component test suite (
components/LaunchButton) from enzyme to React Testing Library, continuing the enzyme → RTL migration (components, one directory per PR).Files migrated off
mountWithContexts/enzyme ontorenderWithContexts:LaunchButton,ReLaunchDropDown.Launch/relaunch are driven through the real button and dropdown menu items and asserted via the launch API calls + resulting
historynavigation; the error path asserts theError!AlertModal. (Also fixed a duplicate test name so both the project- and inventory-sync relaunch cases run distinctly.) Behaviour and assertions are preserved.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
npm testforcomponents/LaunchButton: 3 suites, 14 tests, all passing. ESLint clean (--no-ignore). No production code changed — test-only.