Fix css for PF 5 - #507
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the UI dark mode overrides to restore expected background colors after the PatternFly 5 upgrade, aligning PF component surfaces and a few app-specific layouts with the intended dark theme palette.
Changes:
- Adjusts dark theme backgrounds for the PF masthead and page main sections.
- Tweaks editor gutter active-line and subform layout backgrounds to match the dark theme.
Comment on lines
187
to
191
| html.pf-v5-theme-dark .pf-v5-c-masthead { | ||
| box-shadow: none; | ||
| border-bottom: 1px solid var(--pf-v5-global--BorderColor--200); | ||
| background-color: #13161b; | ||
| } |
Comment on lines
234
to
+236
| html.pf-v5-theme-dark .pf-v5-c-page__main-section.pf-m-light { | ||
| --pf-v5-c-page__main-section--BackgroundColor: inherit; | ||
| background-color: #13161b; | ||
| } |
Comment on lines
+238
to
240
| html.pf-v5-theme-dark .pf-v5-c-page__main-section { | ||
| background-color: #13161b; | ||
| } |
Comment on lines
+255
to
+257
| html.pf-v5-theme-dark .ace-tm .ace_gutter-active-line { | ||
| background-color: #13161b; | ||
| } |
Comment on lines
+257
to
261
| } | ||
|
|
||
|
|
||
|
|
||
| html.pf-v5-theme-dark .pf-v5-c-tab-content { |
Comment on lines
+647
to
+649
| html.pf-v5-theme-dark [class*="FormLayout__SubFormLayout"] { | ||
| background-color: #13161b; | ||
| } No newline at end of file |
TheWitness
approved these changes
Jun 25, 2026
TheWitness
left a comment
TheWitness
left a comment
Collaborator
There was a problem hiding this comment.
Lot's of copilot comments. I'll leave it to you to assess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few background colors that changed during the upgrade to PF 5 (new classes).