Remove redundant mock-socket devDependency - #515
Merged
Conversation
mock-socket is a direct dependency of jest-websocket-mock and is installed automatically as a transitive dep. The project never imports mock-socket directly - the explicit devDependency entry is unnecessary.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant UI devDependency (mock-socket) since it’s already pulled in transitively via jest-websocket-mock, and the codebase does not import mock-socket directly.
Changes:
- Removed
mock-socketfromawx/ui/package.jsondevDependencies. - Updated
awx/ui/package-lock.jsonto reflect removal of the direct devDependency entry (while retaining the transitive install viajest-websocket-mock).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| awx/ui/package.json | Drops redundant direct mock-socket devDependency. |
| awx/ui/package-lock.json | Removes the top-level devDependency entry for mock-socket while keeping it as a transitive dependency. |
Files not reviewed (1)
- awx/ui/package-lock.json: Generated file
cigamit
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove mock-socket from devDependencies - it is redundant.
installed automatically as a transitive dep
ISSUE TYPE
COMPONENT NAME
ASCENDER VERSION
ADDITIONAL INFORMATION
Identified by auditing npm devDependencies for redundant entries.