Fix NotificationTemplate Add error - #518
Merged
Merged
Conversation
cigamit
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the Notification Template “Add” flow by preventing the custom-messages reset effect from dereferencing missing defaults when the notification type is still empty ('') under React 18 StrictMode.
Changes:
- Adds a defensive guard to exit the reset effect early when
defaultMessages[type]is undefined. - Prevents StrictMode’s double-invoked mount effect from crashing before a valid notification type is selected.
TheWitness
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash happened because the effect read defs.started while defs (i.e. defaultMessages[type]) was undefined — type is '' on the Add form, and under React 18 StrictMode the effect re-runs on mount, bypassing the mountedRef guard. Added an early if (!defs) return; so the reset logic only runs once a valid notification type is selected.