Skip to content

Suppress i18next/no-literal-string for pre-i18n loading text - #549

Merged
cigamit merged 1 commit into
ctrliq:mainfrom
blaipr:fix/app-loading-literal-lint
Jun 28, 2026
Merged

Suppress i18next/no-literal-string for pre-i18n loading text#549
cigamit merged 1 commit into
ctrliq:mainfrom
blaipr:fix/app-loading-literal-lint

Conversation

@blaipr

@blaipr blaipr commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adds an eslint-disable-next-line for the i18next/no-literal-string rule on the loading text in App.js (line 208)
  • This text renders before I18nProvider is active, so it cannot use the t macro for translation
  • Fixes the new lint violation introduced by eslint-plugin-i18next 6.1.5 (Bump eslint-plugin-i18next from 6.1.4 to 6.1.5 #537)

Test plan

  • npm run lint passes in awx/ui

test
Suppress i18next/no-literal-string for pre-i18n loading text
1b85245 
The loading text in App.js renders before I18nProvider is active,
so it cannot use the t`` macro. Suppress the lint rule on that line
to fix the new violation introduced by eslint-plugin-i18next 6.1.5.
@blaipr blaipr mentioned this pull request Jun 28, 2026
Merged
2 tasks
@cigamit cigamit self-assigned this Jun 28, 2026
@cigamit
cigamit merged commit b170b9b into ctrliq:main Jun 28, 2026
sy-base pushed a commit to sy-base/ascender that referenced this pull request Jul 4, 2026
@blaipr test @sy-base
Suppress i18next/no-literal-string for pre-i18n loading text (ctrliq#549
643cba0 
)

The loading text in App.js renders before I18nProvider is active,
so it cannot use the t`` macro. Suppress the lint rule on that line
to fix the new violation introduced by eslint-plugin-i18next 6.1.5.

Co-authored-by: test <test@test.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cigamit cigamit cigamit approved these changes

Assignees

@cigamit cigamit

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blaipr @cigamit