Fix failing pinned sliced host test#585
Merged
Merged
Conversation
cigamit
added
bug
TheWitness
approved these changes
Jul 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts unit tests for the job fact-cache pre/post hooks to account for the new pinned sliced host behavior, ensuring the tests don’t fail due to MagicMock(spec=Job) returning a truthy mock for the job_slice_pinned_hosts_list property.
Changes:
- Explicitly sets
job.job_slice_pinned_hosts_list = []in two unit tests so host slicing logic receives an empty/falsey pinned-hosts value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test is currently failing for the new pinned sliced host feature, even though it didn't appear to fail before merging the original feature. Simple fix.