Skip to content

GitHub CI - #647

Merged
cigamit merged 10 commits into
mainfrom
github_ci
Aug 12, 2026
Merged

GitHub CI#647
cigamit merged 10 commits into
mainfrom
github_ci

Conversation

@cigamit

@cigamit cigamit commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
SUMMARY

This adds a CI test suite to all PRs. This is the basics for now, based on the upstream CI from when we forked. We may change it a bit based on discussion in #632

Also, there were lots of flake8 and black issues, so I went ahead and fixed them in here too to ensure all future PRs don't error on old stuff.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other

@cigamit
cigamit requested review from TheWitness and a lite review from Copilot August 11, 2026 15:40
@cigamit cigamit self-assigned this Aug 11, 2026
@cigamit cigamit added the enhancement New feature or request label Aug 11, 2026
@cigamit cigamit changed the title GitHub ci GitHub CI Aug 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new GitHub Actions CI workflow that runs a baseline set of API/UI checks and a docker-compose smoke test on every pull request, along with a set of mechanical formatting/cleanup changes to reduce lint noise and keep existing tests/code compliant.

Changes:

  • Add a new .github/workflows/ci.yml workflow to run API tests/migrations/lint + UI lint/tests, plus a docker-compose-based smoke test job.
  • Add composite GitHub Actions to build the ascender_devel image and to start/wait for the dev docker-compose environment.
  • Apply formatting-only cleanups across various Python modules/tests and tighten some linter configuration.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tox.ini Pins Black and updates Flake8 exclude list for cleaner lint runs.
Makefile Aligns docker-runner mount/workdir to /awx_devel to match container expectations.
awxkit/test/test_ws.py Removes trailing blank line (format-only).
awxkit/test/cli/test_format.py Reflows a YAML string literal (format-only).
awxkit/awxkit/yaml_file.py Removes stray whitespace line (format-only).
awxkit/awxkit/ws.py Removes stray whitespace line (format-only).
awxkit/awxkit/utils/__init__.py Normalizes Unicode escapes (format-only).
awxkit/awxkit/cli/resource.py Removes stray whitespace line (format-only).
awxkit/awxkit/cli/options.py Removes stray whitespace line (format-only).
awxkit/awxkit/cli/client.py Removes stray whitespace line (format-only).
awxkit/awxkit/cli/__init__.py Removes stray whitespace line (format-only).
awxkit/awxkit/awx/utils.py Removes stray whitespace line (format-only).
awxkit/awxkit/awx/inventory.py Simplifies a call-site formatting (format-only).
awxkit/awxkit/api/utils.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/pages/roles.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/pages/page.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/pages/notification_templates.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/pages/inventory.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/pages/execution_environments.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/pages/credentials.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/pages/base.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/mixins/has_notifications.py Removes stray whitespace line (format-only).
awxkit/awxkit/api/client.py Removes stray whitespace line (format-only).
awx/ui/conf.py Reflows a translated help_text string (format-only, but affects readability).
awx/main/tests/functional/test_inventory_input_constructed.py Removes trailing blank lines (format-only).
awx/main/tests/functional/models/test_host_summary_fields.py Reflows object creation calls (format-only).
awx/main/tests/functional/commands/test_inventory_import.py Reflows object creation calls (format-only).
.github/workflows/ci.yml Adds a PR-triggered CI workflow running API/UI checks and a smoke test.
.github/actions/run_awx_devel/action.yml Adds a composite action to bring up docker-compose and wait for API readiness.
.github/actions/awx_devel_image/action.yml Adds/updates a composite action to build/pull/tag the ascender_devel image for CI use.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tox.ini Outdated
Comment thread awx/ui/conf.py Outdated
Comment thread .github/actions/run_awx_devel/action.yml
Comment thread .github/actions/run_awx_devel/action.yml Outdated
Comment thread .github/workflows/ci.yml
Comment thread .github/actions/run_awx_devel/action.yml
Comment thread .github/actions/awx_devel_image/action.yml
Copilot AI review requested due to automatic review settings August 11, 2026 17:59
TheWitness
TheWitness previously approved these changes Aug 11, 2026
@TheWitness

Copy link
Copy Markdown
Collaborator

@cigamit, some copilot comments and CI failures. Approved. Let me know if/when you need me to review again.

Copilot stopped reviewing on behalf of cigamit due to an error August 11, 2026 18:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 19:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 21:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 21:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 22:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 11, 2026 23:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@cigamit
cigamit merged commit ec47ba0 into main Aug 12, 2026
7 checks passed
@cigamit
cigamit deleted the github_ci branch August 12, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

3 participants