Skip to content

fix: show version tag/name in Plans page breadcrumb instead of UUID#1051

Merged
adityachoudhari26 merged 2 commits intomainfrom
claude/issue-1037-20260423-1737
Apr 23, 2026
Merged

fix: show version tag/name in Plans page breadcrumb instead of UUID#1051
adityachoudhari26 merged 2 commits intomainfrom
claude/issue-1037-20260423-1737

Conversation

@adityachoudhari26
Copy link
Copy Markdown
Member

Fixes #1037

The Plans page breadcrumb was showing the raw plan UUID instead of the version tag or name.

Changes:

  • Updated the results tRPC procedure to include version info in the response
  • Updated the breadcrumb to display version.tag ?? version.name ?? planId

Generated with Claude Code

Closes #1037

Co-authored-by: Aditya Choudhari <adityachoudhari26@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 23, 2026 17:40
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@adityachoudhari26 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 21 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 34 minutes and 21 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 83b7c9c7-621b-4c18-862c-b6c5c6ce572f

📥 Commits

Reviewing files that changed from the base of the PR and between a3fa8f2 and babf7b3.

📒 Files selected for processing (2)
  • apps/web/app/routes/ws/deployments/page.$deploymentId.plans.$planId.tsx
  • packages/trpc/src/routes/deployment-plans.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-1037-20260423-1737

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ adityachoudhari26
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Plans detail page breadcrumb to display a human-friendly deployment version identifier (tag/name) instead of the raw plan UUID by including version information in the deployment.plans.results tRPC response.

Changes:

  • Extended deployment.plans.results to return { version, results } rather than only an array of results.
  • Updated the plan detail route to consume the new response shape and render version in the breadcrumb (with fallback to planId).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/trpc/src/routes/deployment-plans.ts Adds versionTag/versionName to the plan lookup and returns version info alongside the results list.
apps/web/app/routes/ws/deployments/page.$deploymentId.plans.$planId.tsx Adapts to the new tRPC response shape and renders version label in the breadcrumb.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +179 to +181
<BreadcrumbPage className="font-mono">
{version?.tag ?? version?.name ?? planId}
</BreadcrumbPage>
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breadcrumb label currently prefers version.tag over version.name. Issue #1037 (and other UI usages) indicate the opposite preference (show name when present, otherwise tag). Consider switching the order to version?.name ?? version?.tag ?? planId (or equivalent), so a friendly name is shown when available.

Copilot uses AI. Check for mistakes.
});
return {
version: { tag: plan.versionTag, name: plan.versionName },
results: rows.map((r) => {
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tRPC procedure is named results and now returns an object with a results property, which forces consumers into ...results.results... and makes the API/type usage harder to read. Consider renaming the response field (e.g., items, rows, targets) or renaming the procedure so the output shape is less confusing.

Suggested change
results: rows.map((r) => {
items: rows.map((r) => {

Copilot uses AI. Check for mistakes.
Comment on lines +38 to +39
type Result =
RouterOutputs["deployment"]["plans"]["results"]["results"][number];
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor readability/maintainability: RouterOutputs["deployment"]["plans"]["results"]["results"][number] is hard to scan. Consider introducing an intermediate alias for the full response type (e.g., type ResultsResponse = RouterOutputs[...]["results"];) and then deriving Result from ResultsResponse["results"][number].

Suggested change
type Result =
RouterOutputs["deployment"]["plans"]["results"]["results"][number];
type ResultsResponse = RouterOutputs["deployment"]["plans"]["results"];
type Result = ResultsResponse["results"][number];

Copilot uses AI. Check for mistakes.
@adityachoudhari26 adityachoudhari26 merged commit ee4f0c8 into main Apr 23, 2026
9 of 10 checks passed
@adityachoudhari26 adityachoudhari26 deleted the claude/issue-1037-20260423-1737 branch April 23, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plans page header should show version

3 participants