chore: fix relay build and improve dev setup#927
chore: fix relay build and improve dev setup#927adityachoudhari26 merged 4 commits intoctrlplanedev:mainfrom
Conversation
- Add root Makefile with unified commands for TS + Go (make start, make test, make lint, make format, make db-*) - Add make start reset=True to wipe Docker volumes for a clean slate - Fix apps/relay/main.go: package relay → package main (was producing ar archive instead of binary) - Add apps/relay/.air.toml for hot-reload via Air - Add apps/relay/.gitignore to exclude bin/ and tmp/ build artifacts - Update README.md Contributing section with numbered steps, prereqs, validate URL, and reset instructions - Update CLAUDE.md to reference Makefile commands, add e2e test section, React patterns Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughDocumentation rewritten into Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
apps/relay/.gitignore (1)
33-43: Ignore Air build log artifact as well.
apps/relay/.air.tomlwritesbuild-errors.log, but it isn’t ignored here. Add it to avoid local noise and accidental commits.Suggested diff
# Debug files debug +build-errors.log🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/relay/.gitignore` around lines 33 - 43, Add the Air build log artifact "build-errors.log" to the existing .gitignore entries so that the file created by .air.toml isn't accidentally committed; update the apps/relay/.gitignore by appending "build-errors.log" (or a pattern matching that filename) alongside the other ignored debug/temp/binary entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CLAUDE.md`:
- Around line 9-11: The markdown in CLAUDE.md has several fenced code blocks
missing a language identifier (MD040); update each fence (including the block
showing "Your CI/CD → Ctrlplane (orchestrates) → Your Infrastructure" and
the blocks around lines 58-72 and 104-110) to include a language tag such as
"text" (e.g., replace ``` with ```text) so the linter is satisfied while
preserving the existing block contents.
In `@Makefile`:
- Line 32: The Makefile uses the incorrect pnpm workspace filter "-F db" in
multiple targets; update the four occurrences in the start, db-migrate, db-push,
and db-studio targets to use the correct workspace name "-F `@ctrlplane/db`" so
pnpm commands target the `@ctrlplane/db` package (replace "-F db" with "-F
`@ctrlplane/db`" in the flox activate line in the start target and in the pnpm
commands inside db-migrate, db-push, and db-studio).
---
Nitpick comments:
In `@apps/relay/.gitignore`:
- Around line 33-43: Add the Air build log artifact "build-errors.log" to the
existing .gitignore entries so that the file created by .air.toml isn't
accidentally committed; update the apps/relay/.gitignore by appending
"build-errors.log" (or a pattern matching that filename) alongside the other
ignored debug/temp/binary entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a47ba074-b1b9-4179-90f8-1cd25de5df5b
📒 Files selected for processing (6)
CLAUDE.mdMakefileREADME.mdapps/relay/.air.tomlapps/relay/.gitignoreapps/relay/main.go
- Delete Makefile per reviewer feedback - Revert README.md Contributing section to original (no make commands) - Add fence language specifiers to all unlabeled code blocks (MD040) - Replace make commands in CLAUDE.md with direct pnpm/go commands - Fix pnpm -F db → pnpm -F @ctrlplane/db throughout - Remove apps/relay/.gitignore; add Go/relay entries to root .gitignore Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Jagat Thakkar <32109558+jthakkar04@users.noreply.github.com>
Summary
apps/relay/main.go:package relay→package main(was producing an ar archive instead of a binary, causing Air to crash with!<arch>)apps/relay/.air.tomlfor hot-reload via Air, withchmod +xto handle permission on the built binary.gitignore(*.exe,*.dylib,*.test,apps/relay/bin/,build-errors.log, etc.)CLAUDE.md: add architecture overview, e2e test section, React/builder pattern notes, and direct pnpm/go commands (no Makefile dependency)README.mdandCLAUDE.mdTest plan
!<arch>or permission denied errors (cd apps/relay && air)http://localhost:5173/to confirm the app loads after a clean setup🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Chores