docs: enhance contributing section in README#952
Conversation
- Add detailed prerequisites with links (Docker, Flox, pnpm, Go) - Expand first-time setup with step comments and a reset guide - Add day-to-day development commands table - Add database, E2E tests, and workspace-engine (Go) sections - Add monorepo structure overview - Add code style guidelines - Add pull request workflow instructions Co-authored-by: Aditya Choudhari <adityachoudhari26@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughUpdated README.md with an expanded contribution and setup guide. Replaced manual "Local Setup" instructions with comprehensive workflows including Docker Compose startup, pnpm installation, scoped database migrations, and new sections covering day-to-day commands, database helpers, E2E tests, workspace-engine operations, directory structure, and code-style guidelines. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
There was a problem hiding this comment.
Pull request overview
Enhances the README’s contributing section to give contributors clearer local setup, common workflows, and repo orientation.
Changes:
- Expanded prerequisites and first-time local setup steps (Docker, Flox/pnpm, DB migrations, dev servers).
- Added day-to-day development commands plus dedicated DB and Playwright E2E guidance.
- Documented monorepo structure, code style expectations, and a basic PR workflow checklist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - [Docker](https://docs.docker.com/get-docker/) engine installed and running | ||
| - [Flox](https://flox.dev/docs/install-flox/install/) installed (manages Node.js, pnpm, Go, and other tooling) | ||
| - [pnpm](https://pnpm.io/installation) (if not using Flox) | ||
| - [Go 1.22+](https://go.dev/dl/) (only needed if working on `workspace-engine` or `relay`) |
There was a problem hiding this comment.
The Go version requirement here looks out of date. apps/workspace-engine/go.mod specifies go 1.25.7 and apps/relay/go.mod specifies go 1.25.4, so Go 1.22+ will not be sufficient for contributors working on these apps. Please update the prerequisite to match the repository’s current minimum Go version (likely 1.25+).
| - [Go 1.22+](https://go.dev/dl/) (only needed if working on `workspace-engine` or `relay`) | |
| - [Go 1.25+](https://go.dev/dl/) (only needed if working on `workspace-engine` or `relay`) |
| ```bash | ||
| cd apps/workspace-engine | ||
| go run ./... # Run without building | ||
| go build -o ./bin/workspace-engine . # Build binary | ||
| go test ./... # Run tests |
There was a problem hiding this comment.
go run ./... will fail in this module because ./... expands to multiple packages including more than one package main (e.g., . and tools/seed). Use a single main package target (for example go run .) so the command works as written.
Enhances the contributing section in README.md with detailed setup instructions, day-to-day commands, E2E test guidance, monorepo structure, code style guidelines, and PR workflow.
Resolves #913
Generated with Claude Code
Summary by CodeRabbit