Updated send email to handle html body#2
Merged
Conversation
mehuljhaver4
reviewed
Oct 5, 2023
Contributor
mehuljhaver4
left a comment
There was a problem hiding this comment.
- You can remove the print statements on
line 98 and 101 - The code in general works as expected.
- Not sure if we will have this edge case but it fails when there's
"\n"and"<some html tag>"in the body of the message. - Example:
"This is \n a Python Script. <p> Testing the script"
Contributor
Author
|
@mehuljhaver4 |
Contributor
Author
|
@mbentz-uf |
michael-bentz
approved these changes
Oct 12, 2023
Contributor
|
@mehuljhaver4 Can you try now? |
Contributor
|
#3 would be a nice-to-have in the future. |
Contributor
Merging is still blocked @mbentz-uf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do? Please be clear and concise.
Changes
send_email()function to handlehtmlcontent in the body. Strings in body have no impact and render as usual.Why was this change made? Including an issue number is sufficient. Otherwise, briefly explain the benefit of the change.
send_email()parsed the html code in the body as string and sent the complete code instead of rendering the html.Verification
NA
Affirmations
All of these should have a check by them. Any exception requires an explanation.
README,CHANGELOG, and such).