Add _contains_html function#9
Merged
Merged
Conversation
mehuljhaver4
approved these changes
Nov 6, 2023
Contributor
mehuljhaver4
left a comment
There was a problem hiding this comment.
- Verified the logic of the test_contains_html unit test
- Verified that all automated workflows passed
| html_markup = "<html><p></p></html>" | ||
| non_html_text = "This is a sentence with special characters, < ? ! . '" | ||
|
|
||
| self.assertEquals(True, utils._contains_html(html_markup)) |
Contributor
There was a problem hiding this comment.
line 16 and similar lines show the following problem:
Cannot access member "assertEquals" for type "TestUtils" Member "assertEquals" is unknownPylanc reportGeneralTypeIssues
But the tests run successfully
Contributor
Author
There was a problem hiding this comment.
I'm not sure how you're getting this. I don't see it locally and the lint workflow is passing.
Contributor
There was a problem hiding this comment.
Must be some issue at my end. I'll merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Adds
_contains_htmlfunction with unit tests.Why was this change made?
To close #3.
Verification
Affirmations
All of these should have a check by them. Any exception requires an explanation.
README,CHANGELOG, and such).