You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Verified against packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts:109,416-417 — the option exists and is applied on connection. The #driver_factory anchor also resolves in reference/configuration/config.mdx.
Verdict: ship-able. One minor link nit and a couple of small suggestions.
Findings — 0 blocking, 1 minor, 2 nits
Minor — link points to a page that doesn't mention QUERY_TAG
This is the exact same URL as [snowflake-docs-connection-options] on the line above, and the "Additional connection options" section on that page does not actually document QUERY_TAG — the reader clicks "query tag" and lands on a generic connection-options table. Snowflake's canonical page for the session parameter is:
That page explains what QUERY_TAG does, its length limit (2000 chars), and how it surfaces in QUERY_HISTORY — which is exactly what someone following the "query tag" link would want to read.
Nit — section placement
### Query tagging sits as an H3 under ## Setup alongside "Manual" and "Cube Cloud", but it isn't a setup mode — it's an optional post-setup config for either. Consider promoting it to an H2 (e.g. ## Query tagging) after ## Setup, or nesting it under a general "Additional configuration" heading. Not blocking; the current placement is still discoverable.
Nit — reader may wonder about connection details
The driverFactory example only passes queryTag, which works because SnowflakeDriver's constructor falls back to CUBEJS_DB_* env vars for account/warehouse/user/pass — but that's not obvious from the snippet alone. A one-line reassurance ("other connection settings continue to be read from CUBEJS_DB_* env vars") would head off a common "did I just wipe out my connection?" question. Optional.
💡 Tip: Enable Workflows to automatically generate PRs for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queryTagconnection option, which had no docs since it shipped (feat(snowflake-driver): Add queryTag connection parameter #9889)driverFactory, since there's no env var for itTest plan