Skip to content

docs(snowflake): document queryTag connection option - #11364

Merged
igorlukanin merged 1 commit into
masterfrom
igor/snowflake-query-tag-docs
Jul 27, 2026
Merged

docs(snowflake): document queryTag connection option#11364
igorlukanin merged 1 commit into
masterfrom
igor/snowflake-query-tag-docs

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

Summary

Test plan

  • Preview renders correctly in Mintlify (heading, code block, links resolve)

@igorlukanin
igorlukanin requested a review from keydunov as a code owner July 27, 2026 08:17
@claude

claude Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 24s —— View job


Review: docs(snowflake): document queryTag connection option

Verified against packages/cubejs-snowflake-driver/src/SnowflakeDriver.ts:109,416-417 — the option exists and is applied on connection. The #driver_factory anchor also resolves in reference/configuration/config.mdx.

Verdict: ship-able. One minor link nit and a couple of small suggestions.

Findings — 0 blocking, 1 minor, 2 nits

Minor — link points to a page that doesn't mention QUERY_TAG

docs-mintlify/admin/connect-to-data/data-sources/snowflake.mdx:401

[snowflake-docs-query-tag]: https://docs.snowflake.com/en/developer-guide/node-js/nodejs-driver-options#additional-connection-options

This is the exact same URL as [snowflake-docs-connection-options] on the line above, and the "Additional connection options" section on that page does not actually document QUERY_TAG — the reader clicks "query tag" and lands on a generic connection-options table. Snowflake's canonical page for the session parameter is:

https://docs.snowflake.com/en/sql-reference/parameters#query-tag

That page explains what QUERY_TAG does, its length limit (2000 chars), and how it surfaces in QUERY_HISTORY — which is exactly what someone following the "query tag" link would want to read.

Nit — section placement

### Query tagging sits as an H3 under ## Setup alongside "Manual" and "Cube Cloud", but it isn't a setup mode — it's an optional post-setup config for either. Consider promoting it to an H2 (e.g. ## Query tagging) after ## Setup, or nesting it under a general "Additional configuration" heading. Not blocking; the current placement is still discoverable.

Nit — reader may wonder about connection details

The driverFactory example only passes queryTag, which works because SnowflakeDriver's constructor falls back to CUBEJS_DB_* env vars for account/warehouse/user/pass — but that's not obvious from the snippet alone. A one-line reassurance ("other connection settings continue to be read from CUBEJS_DB_* env vars") would head off a common "did I just wipe out my connection?" question. Optional.

· [Branch](https://github.com/cube-js/cube/tree/igor/snowflake-query-tag-docs)

@mintlify

mintlify Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Jul 27, 2026, 8:18 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@igorlukanin
igorlukanin merged commit 2140de5 into master Jul 27, 2026
14 checks passed
@igorlukanin
igorlukanin deleted the igor/snowflake-query-tag-docs branch July 27, 2026 08:21
@mintlify

mintlify Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟡 Building Jul 27, 2026, 8:17 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant