docs: explain editable SAML audience (CUB-2546) - #11706
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @MikeNitsenko's task in 1m 42s —— View job Docs review: SAML audience guidanceVerdict: looks good to merge after a few small edits — 0 blocking, 2 medium, 2 low. Content is accurate and internally consistent; findings are structure/wording only. 4 inline comments posted. Full reviewChecklist
What works well
Findings
Verify with the product before merging
Notes on the PR descriptionThe Mintlify build/link check didn't run locally per the description. I did not run it either (dependency install is the same blocker); the anchor and image checks above were done by grep across |
|
Implementation PR: https://github.com/cubedevinc/cubejs-enterprise/pull/14576 |
f49ea76 to
5a56182
Compare
|
Claude finished @MikeNitsenko's task in 47s —— View job Re-review after
|
| # | Prior finding | Status |
|---|---|---|
| 1 | index.mdx — new #### subsection nested the provider cards under it |
Fixed — #### Match SAML service provider identifiers now sits after the <CardGroup> (admin/sso/index.mdx:46), so the cards stay directly under ### SAML |
| 2 | Entra audience claim override was a no-op for new integrations | Fixed — step 3 is now conditional: "If the Audience (SP Entity ID) value from Cube differs from the Entity ID configured in the previous step… If the values match, no audience claim override is required." (microsoft-entra-id/saml.mdx:62-65) |
| 3 | Google page missing the "For a new integration" qualifier | Fixed — google-workspace.mdx:25; also picks up the prefill nuance I flagged separately ("replace any prefilled … value") |
| 4 | Duplicate 5. in the Google ordered list |
Fixed — renumbered to 6. / 7. (google-workspace.mdx:72-74) |
All four threads are now resolved (three were auto-resolved by the push; I resolved the outdated Entra one).
Verification I re-ran
#enable-saml-in-cube-cloudatgoogle-workspace.mdx:152still resolves — the first## Enable SAML in Cube Cloudheading (line 18) is intact; only the second duplicate heading was renamed to## Complete SAML configuration in Cube Cloud.- No remaining references anywhere in
docs-mintlifyto the three removeducarecdn.comscreenshots, nor to the oldService Provider Entity IDlabel. - Ordered-list numbering is now sequential on all touched lists.
- Field labels are consistent across the four pages: Audience (SP Entity ID) / Single Sign-On URL on the Cube side, Entity ID / Issuer, SSO (Sign on) URL, Certificate on the IdP side.
Still worth a product confirmation before merge (unchanged from last review, not a code issue)
- "A blank Audience disables audience validation" is now stated as fact on four pages (
index.mdx:55-58,google-workspace.mdx:108). That behavior lives in the enterprise repo, not here — worth a nod from whoever owns the SAML backend (implementation PR presumably covers it). - Cosmetic and pre-existing, out of scope:
admin/sso/index.mdx:7has a strayAuthentication & SSOline with a leading space that looks like a heading that lost its##.
Not run
Mintlify build / link checker — dependency install is the same blocker described in the PR body. Anchor and image checks above were done by grep across docs-mintlify. CI should still validate.
Summary
Compatibility
Existing working integrations are told not to change. Blank Audience remains documented as a compatibility mode that disables validation; enabling validation requires changing both sides and testing with a fallback authentication method enabled.
Ticket: https://linear.app/cube-d3/issue/CUB-2546/support-aws-federate-for-sso-setup
Validation