Skip to content

fix: Throw a user-friendly error on an empty cube.py file #9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

fix: Throw a user-friendly error on an empty cube.py file #9550

merged 2 commits into from
May 7, 2025

Conversation

@ovr
Copy link
Member

@ovr ovr commented May 7, 2025

image

@ovr ovr requested a review from a team as a code owner May 7, 2025 12:17
KSDaemon
KSDaemon approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

igorlukanin
igorlukanin reviewed May 7, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.37%. Comparing base (785142d) to head (9ae3201).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9550      +/-   ##
==========================================
- Coverage   80.38%   80.37%   -0.01%     
==========================================
  Files         395      395              
  Lines       97932    97941       +9     
  Branches     2278     2279       +1     
==========================================
+ Hits        78723    78724       +1     
- Misses      18901    18908       +7     
- Partials      308      309       +1
Flag Coverage Δ
cube-backend 57.30% <ø> (-0.04%) ⬇️
cubesql 84.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr @igorlukanin
Thanks @igorlukanin
9ae3201 
Co-authored-by: Igor Lukanin <igor@cube.dev>
@ovr ovr changed the title fix: Throw user friendly error on empty cube.py file fix: Throw a user-friendly error on an empty cube.py file May 7, 2025
@ovr ovr merged commit d69222c into master May 7, 2025
72 checks passed
@ovr ovr deleted the fix/friendly-error-on-empty-cube-py branch May 7, 2025 13:12
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
@ovr @igorlukanin @marianore-muttdata
fix: Throw a user-friendly error on an empty cube.py file (cube-js#9550)
624eb76 
Co-authored-by: Igor Lukanin <igor@cube.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorlukanin igorlukanin igorlukanin left review comments

@KSDaemon KSDaemon KSDaemon approved these changes

@RusovDmitriy RusovDmitriy RusovDmitriy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ovr @KSDaemon @igorlukanin @RusovDmitriy