Skip to content

fix: Throw a user-friendly error on an empty cube.py file #9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

fix: Throw a user-friendly error on an empty cube.py file #9550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7ff048
fix: Throw user friendly error on empty cube.py file
ovr May 7, 2025
9ae3201
Thanks @igorlukanin
ovr May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/cubejs-backend-native/src/python/entry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use crate::python::neon_py::*;
use crate::python::python_model::CubePythonModel;
use crate::python::runtime::py_runtime_init;
use neon::prelude::*;
use pyo3::exceptions::PyException;
use pyo3::prelude::*;
use pyo3::types::{PyDict, PyFunction, PyList, PyString, PyTuple};
use std::path::Path;
Expand Down Expand Up @@ -45,8 +46,15 @@ fn python_load_config(mut cx: FunctionContext) -> JsResult<JsPromise> {
let settings_py = if config_module.hasattr("config")? {
config_module.getattr("config")?
} else {
// backward compatibility
config_module.getattr("settings")?
// backward compatibility, was used in private preview, not as Public API
// TODO: Remove after 1.4
if config_module.hasattr("settings")? {
config_module.getattr("settings")?
} else {
return Err(PyErr::new::<PyException, String>(
"`cube.py` configuration file must define the 'config' attribute. Did you forget to add the `from cube import config` import?".to_string(),
));
}
};

let mut cube_conf = CubeConfigPy::new();
Expand Down Expand Up @@ -119,6 +127,8 @@ fn python_load_model(mut cx: FunctionContext) -> JsResult<JsPromise> {
);
}
} else {
// backward compatibility, was used in private preview, not as Public API
// TODO: Remove after 1.4
let inspect_module = py.import("inspect")?;
let args = (model_module, inspect_module.getattr("isfunction")?);
let functions_with_names = inspect_module
Expand Down
Loading