Skip to content

Conversation

@brasmusson
Copy link
Contributor

In v1.3.x the listing of failed scenarios use the line number for the scenario outline for when a outline example fails. This is inconsistent with what the rerun formatter output, where the line number of the example row is used. If the intention is that the listing of failed scenarios shall define commands that can be used to run the failed scenarios, the line number for the scenario outline works, but is a bit overkill, since using that line number will execute all examples for the scenario outline.

Currently the behaviour on v2.0 branch is to instead use the line number of the example row in the listing of the failed scenarios. This is both consistent with the rerun formatter output, and gives a more specific command to rerun the failed scenario.

Therefore I propose to "fix" the issue by changing the expected output in the outlines.feature (which still will be tagged @wip-new-core due to other remaining issues).

@os97673
Copy link
Member

os97673 commented Aug 1, 2014

Looks ok for me. @mattwynne are you ok with proposed solution?

@mattwynne
Copy link
Member

Great! @brasmusson I'd be happy for you to push things like this straight to master, just with a comment in the commit. You have push rights, don't you?

mattwynne added a commit that referenced this pull request Aug 4, 2014
Expect table row line number for failing scenario from outline
@mattwynne mattwynne merged commit 36b4871 into cucumber:master Aug 4, 2014
@brasmusson brasmusson deleted the outline-line-numbers branch August 4, 2014 17:27
@brasmusson
Copy link
Contributor Author

@mattwynne Yes, I have push rights, so far I almost exclusively worked on Cucumber-JVM + Gherkin/Java, so I appear there on the team page.
OK, then I know that pushing to master with a comment, is an alternative when the change is "strait forward" enough.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants