Skip to content

Conversation

@brasmusson
Copy link
Contributor

To fix the pretty formatter scenarios in the outlines.feature the following two changes are needed:
-- Use the outline step name in the error backtrace, instead of the instantiated step name (requires cucumber/cucumber-ruby-core#60).
-- Do not call formatter.exception for outline failures in the legacy_formatter (as inconsistent as it might seem, this is the behaviour in v1.3.x)

The one scenario in outlines.feature that after this PR is still tagged @wip-new-core, has a diff in the progress formatter output:

 - "--U-..F-.."
 + "------..FF--.."

This PR is built on top of #713

@brasmusson brasmusson merged commit 9d1cdd0 into cucumber:master Aug 6, 2014
brasmusson added a commit that referenced this pull request Aug 6, 2014
@wip-new-core, fix the pretty formatter scenarios in the outlines.feature
@brasmusson
Copy link
Contributor Author

The choice between:
features/outline_sample.feature:6:in Given without a table'(which is the v1.3.x behavoiur and that this PR changes v2.0 to) and:features/outline_sample.feature:6:in Given failing without a table' (which is the current v2.0 behaviour) in the error back trace is not clear cut.

On one hand Given <state> without a table is the actual content of features/outline_sample.feature:6, on the other hand Given failing without a table is the step actually executed.

Well, using the v1.3.x behaviour cannot be that wrong, so I merge this (my own) PR.
(and there are now 15 scenarios tagged @wip-new-core remaining)

@brasmusson brasmusson deleted the outline-feature-fix branch August 6, 2014 19:24
@mattwynne
Copy link
Member

\o/

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants