Skip to content

chore: bump version to 2.1.42 and add address field to LegalPersonReq… - #424

Merged
rogelioLpz merged 1 commit into
mainfrom
feat/save-legal-person-address
Sep 3, 2026
Merged

chore: bump version to 2.1.42 and add address field to LegalPersonReq…#424
rogelioLpz merged 1 commit into
mainfrom
feat/save-legal-person-address

Conversation

@rcabrera-py

@rcabrera-py rcabrera-py commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

…uest and LegalPersonUpdateRequest

  • Updated the version in version.py to 2.1.42.
  • Added an optional address field to LegalPersonRequest and LegalPersonUpdateRequest classes.
  • Updated example schema in LegalPersonRequest to include address.

Summary by CodeRabbit

  • New Features

    • Legal person creation requests now require an address.
    • Legal person updates can optionally include an address.
    • Address fields are now reflected in the related request examples.
  • Updates

    • Updated the validation package to version 2.1.42.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: bb3e2aa6-3935-4df2-9965-b0bbcd3841e8

📥 Commits

Reviewing files that changed from the base of the PR and between 46bae19 and 13b8758.

📒 Files selected for processing (2)
  • cuenca_validations/types/requests.py
  • cuenca_validations/version.py

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

The request models now require an address for LegalPersonRequest and accept an optional address for LegalPersonUpdateRequest. The package version changes from 2.1.41 to 2.1.42.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 13b87

This release adds address support to legal-person request validation and updates the package version. No current merge-blocking risk remains.

Suggested reviewers: rogeliolpz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies both main changes: the version bump to 2.1.42 and the addition of an address field to the legal person request models.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/save-legal-person-address

Comment @coderabbitai help to get the list of available commands.

…uest and LegalPersonUpdateRequest

- Updated the version in version.py to 2.1.42.
- Added an optional address field to LegalPersonRequest and LegalPersonUpdateRequest classes.
- Updated example schema in LegalPersonRequest to include address.
@rcabrera-py
rcabrera-py force-pushed the feat/save-legal-person-address branch from 7fcff31 to 13b8758 Compare September 3, 2026 23:36
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (46bae19) to head (13b8758).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #424   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1521      1523    +2     
=========================================
+ Hits          1521      1523    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cuenca_validations/types/requests.py 100.00% <100.00%> (ø)
cuenca_validations/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46bae19...13b8758. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rogelioLpz
rogelioLpz merged commit f53011f into main Sep 3, 2026
21 checks passed
@rogelioLpz
rogelioLpz deleted the feat/save-legal-person-address branch September 3, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants