Conversation
…ntatively drop this header item pending full CUGOS approval.
njhenry
force-pushed
the
feature/past-flings
branch
from
d003fa6 to
8adf10d
Compare
mizmay
left a comment
mizmay
left a comment
There was a problem hiding this comment.
Nice!
I made couple of suggestions below, to improve site navigation and be robust.
Separately I'll file a couple of issues this change surfaces, not deal-breakers, just worth noting.
| {% for weight in (0..10) %}{% for p in site.pages %}{% if p.weight == weight %} | ||
| {% for weight in (0..10) %}{% if weight == 5 %} | ||
| <li class="dropdown {% if page.url contains 'fling' %}active{% endif %}"> | ||
| <a href="/2025-fall-fling/">Flings <i class="fa fa-caret-down"></i></a> |
There was a problem hiding this comment.
Suggest removing the href tag, otherwise clicking on "Flings" in the top bar still goes to the 2025 event, which is confusing.
There was a problem hiding this comment.
Should this be "Flings" or "Past Flings"?
There was a problem hiding this comment.
Done!
I tested out "Past Flings", but I think I like the look of "Flings" more:
| <li class="dropdown {% if page.url contains 'fling' %}active{% endif %}"> | ||
| <a href="/2025-fall-fling/">Flings <i class="fa fa-caret-down"></i></a> |
There was a problem hiding this comment.
| <li class="dropdown {% if page.url contains 'fling' %}active{% endif %}"> | |
| <a href="/2025-fall-fling/">Flings <i class="fa fa-caret-down"></i></a> | |
| {% assign fling_urls = site.flings | map: 'url' %}<li class="dropdown {% if fling_urls contains page.url %}active{% endif %}"> | |
| <a>Flings <i class="fa fa-caret-down"></i></a> |
A bit more robust, just in case someone in the future ever creates a URL slug that contains the word flings but isn't about a specific fling.
There was a problem hiding this comment.
| #menu li:not(.dropdown):hover a { |
Optional, but this fixes 2 from #428
There was a problem hiding this comment.
Done. The mobile dropdown view is still far from perfect, but at least those lines are gone:
…es comments and readability of the Jekyll logic for building the nav bar.
…nces a CUGOS Fling.
…g titles are still bolded on mouseover only.
3 participants
This PR addresses Issue #274.
Changes:
_includes/nav.htmlwith some new CSS to style the dropdown. To make this a "Jekyll-y" update, fling titles (years), order, and paths are stored in the_config.ymlmetadata. Past flings are sorted in reverse chronological order.You can preview this change by serving the PR locally:
Here are some example screenshots:
Front page:
Front page, dropdown expanded, mouse hovering over "2025":
Narrow viewport, nav menu expanded:
On a fling page: