Conversation
Run \`make build\` on every push to main and every pull request so broken Swift sources or a regressed Makefile fail fast instead of being discovered at release time. Forward-compatible with the upcoming SPM refactor: both the current \`swiftc\`-based Makefile and the SPM-wrapped \`Scripts/package-app.sh\` produce \`build/TermIMS.app\`, which the post- build verification step asserts is signed and has a valid Info.plist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/build.ymlthat runsmake buildonmacos-14for every push tomainand every pull request.build/TermIMS.app/Contents/MacOS/TermIMSexists,Info.plistis valid, and the bundle is code-signed.Forward-compatible with the pending SPM refactor (PR #2): both the current
swiftc-based Makefile and the SPM-wrappedScripts/package-app.shproduce the samebuild/TermIMS.applayout, so the same verification commands work before and after the refactor lands.Test plan