Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

wire/debug trace breaks IE <= 9 #78

Closed
briancavalier opened this Issue Feb 28, 2013 · 3 comments

Comments

Projects
None yet
2 participants
Owner

briancavalier commented Feb 28, 2013

The problem is that trace is very aggressive in trying to advise every possible method of every object. This works fine in sane browsers where builtins, like String, are actually real Javascript objects, but breaks in IE where builtins aren't actually Javascript objects, but rather bizarro IE things.

So, for example, if you have a basic type, like a String, in your wire spec, wire/debug will break as it tries to advise the string's methods.

In limited testing, a reasonable workaround seems to be to limit wire/debug to things that are actually objects via the usual Object.prototype.toString.call(thing) === '[object Object]' test (which avoids arrays as well, obviously).

@ghost ghost assigned briancavalier Feb 28, 2013

Owner

unscriptable commented Feb 28, 2013

it's probably best not to mess with DOM nodes in IE either, so this is probably for the best.

briancavalier added a commit that referenced this issue Feb 28, 2013

Owner

briancavalier commented Feb 28, 2013

Yeah, def. We're already filtering out DOM nodes, thankfully. Interestingly, it's possible to AOP DOM nodes using meld in WebKit! Dunno how useful it would be, though, so yeah, best just to stay away from them across the board for now.

Owner

briancavalier commented Feb 28, 2013

Fixed by 6595244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment