Skip to content

MR-72 Update DefaultAppEventPayloadHandler.java - #253

Merged
Rajesh1041 merged 1 commit into
developfrom
MR-72
May 14, 2026
Merged

MR-72 Update DefaultAppEventPayloadHandler.java#253
Rajesh1041 merged 1 commit into
developfrom
MR-72

Conversation

@Rajesh1041

@Rajesh1041 Rajesh1041 commented May 10, 2026

Copy link
Copy Markdown
Contributor

Changes

  • app/src/main/java/org/curiouslearning/container/core/subapp/handler/DefaultAppEventPayloadHandler.java

How to test

  • Please try logging the payload to the summary_data collection in the release build and verify whether the data is being stored correctly in Firestore.

Ref: MR-72

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of summary data inputs to ensure consistent processing and correct data mapping.
    • Enhanced logging messages when updating summary documents in the database for better operational transparency.

Review Change Stack

@Rajesh1041 Rajesh1041 self-assigned this May 10, 2026
@Rajesh1041
Rajesh1041 requested a review from miguelccodev May 10, 2026 05:31
@coderabbitai

coderabbitai Bot commented May 10, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

DefaultAppEventPayloadHandler is enhanced with an explicit mapping for "summary_data" inputs to the COLLECTION_SUMMARY constant in the normalizeCollection method, and the success log for summary document updates now includes the updated document ID.

Changes

Summary Data Collection Normalization and Logging

Layer / File(s) Summary
Collection Normalization
app/src/main/java/org/curiouslearning/container/core/subapp/handler/DefaultAppEventPayloadHandler.java
normalizeCollection method adds explicit mapping for "summary_data" input to return COLLECTION_SUMMARY constant instead of default fallthrough.
Summary Update Logging
app/src/main/java/org/curiouslearning/container/core/subapp/handler/DefaultAppEventPayloadHandler.java
Success log message for Firestore summary document update is updated to include the existingDoc ID.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • curiouslearning/CRcontainer#246: Adds dispatch and dedicated summary_data handling in the same handler class, extending the normalization logic introduced here.
  • curiouslearning/CRcontainer#247: Implements the summary_data write and merge logic that depends on the collection normalization mapping added in this PR.
  • curiouslearning/CRcontainer#232: Introduces Firestore persistence logic that directly uses the COLLECTION_SUMMARY constant now properly normalized by this PR.

Suggested reviewers

  • miguelccodev

Poem

🐰 A summary springs to light,
With mappings set precisely right,
Logs now shine with document grace,
Each change finds its rightful place!

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Tests & Lint & Coverage ⚠️ Warning No tests added for new DefaultAppEventPayloadHandler.java. Linting not configured in project. Coverage threshold (70%) not enforced in CI/CD. Add unit tests for DefaultAppEventPayloadHandler. Configure and enforce lint checks. Set up JaCoCo coverage threshold enforcement (70%) in CI pipeline.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the file being modified and includes the JIRA key (MR-72), directly matching the PR's main objective of updating DefaultAppEventPayloadHandler.java.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MR-72

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rajesh1041 Rajesh1041 changed the title Update DefaultAppEventPayloadHandler.java MR-72 Update DefaultAppEventPayloadHandler.java May 14, 2026
@Rajesh1041
Rajesh1041 merged commit 82b0186 into develop May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants