Conversation
- Persist confirmed study_user_id after successful study enrollment - Store the study ID alongside the existing pseudoId using a dedicated preference key - Append study_user_id only to app_launch Firebase event parameters when available - Leave unenrolled app_launch events unchanged by omitting study_user_id - Add unit coverage for app_launch events with and without a persisted study_user_id - Restore the existing language_selected analytics test invocation so the test class passes
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR adds persistent study user ID caching to analytics events. AnalyticsUtils introduces constants and a helper to inject cached study user IDs into app_launch events. MainActivity persists confirmed user IDs via the new constant. Tests validate caching behavior with and without cached IDs. App version is bumped to 2.34.3. ChangesStudy User ID Caching and Analytics Integration
App Version Bump
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Changes
How to test
Ref: AJ-657
Summary by CodeRabbit
Version Update
Improvements
Tests