feat: Adding Qr-code Functionality in Cr-container for copying cr_user_id! - #284
Merged
Conversation
📝 WalkthroughWalkthroughThe app adds a QR-code button and overlay for the cached pseudo ID. Users can view the generated QR code and copy the formatted ID. ZXing is added, and the Gradle wrapper is upgraded. ChangesQR ID display
Build tooling
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant MainActivity
participant QRCodeWriter
participant qr_overlay
participant ClipboardManager
User->>MainActivity: Tap show_id_button
MainActivity->>QRCodeWriter: Encode pseudo ID as QR bitmap
MainActivity->>qr_overlay: Show QR image and formatted ID
User->>MainActivity: Tap qr_image or qr_id_text
MainActivity->>ClipboardManager: Copy formatted ID
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/src/main/res/layout/activity_main.xml (1)
114-205: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winMove QR UI text to string resources.
The new labels and instructions are hard-coded in all layout qualifiers. They cannot use resource-qualified translations and can diverge between layouts.
app/src/main/res/layout/activity_main.xml#L114-L205: Reference shared strings for the button description, QR description, and copy instruction.app/src/main/res/layout-sw600dp/activity_main.xml#L121-L191: Reference the same shared strings.app/src/main/res/layout-sw720dp/activity_main.xml#L122-L192: Reference the same shared strings.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/res/layout/activity_main.xml` around lines 114 - 205, Move the hard-coded QR-related labels to shared string resources, then reference those resources for the show-ID button content description, QR image content description, and copy instruction in app/src/main/res/layout/activity_main.xml lines 114-205, app/src/main/res/layout-sw600dp/activity_main.xml lines 121-191, and app/src/main/res/layout-sw720dp/activity_main.xml lines 122-192. Use the same resource keys across all three layouts so translations remain consistent.
🧹 Nitpick comments (1)
gradle/wrapper/gradle-wrapper.properties (1)
2-2: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valueRemove the stale AGP classpath declaration.
app/build.gradleappliesid 'com.android.application'without a version, so Gradle resolves the8.13.1classpath frombuildscript, not the7.3.1plugins declaration.7.3.1is still a redundant conflict; remove it to avoid accidental downgrade if this project is refactored.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@gradle/wrapper/gradle-wrapper.properties` at line 2, Remove the stale Android Gradle Plugin 7.3.1 declaration from the buildscript plugins configuration, leaving the existing 8.13.1 classpath used by the com.android.application plugin unchanged.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@app/src/main/res/layout/activity_main.xml`:
- Around line 114-205: Move the hard-coded QR-related labels to shared string
resources, then reference those resources for the show-ID button content
description, QR image content description, and copy instruction in
app/src/main/res/layout/activity_main.xml lines 114-205,
app/src/main/res/layout-sw600dp/activity_main.xml lines 121-191, and
app/src/main/res/layout-sw720dp/activity_main.xml lines 122-192. Use the same
resource keys across all three layouts so translations remain consistent.
---
Nitpick comments:
In `@gradle/wrapper/gradle-wrapper.properties`:
- Line 2: Remove the stale Android Gradle Plugin 7.3.1 declaration from the
buildscript plugins configuration, leaving the existing 8.13.1 classpath used by
the com.android.application plugin unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: b5c6ceea-de40-4add-a3cb-b2efca4fc02b
⛔ Files ignored due to path filters (1)
app/src/main/res/drawable/coaches_icon_cr.pngis excluded by!**/*.png
📒 Files selected for processing (6)
app/build.gradleapp/src/main/java/org/curiouslearning/container/MainActivity.javaapp/src/main/res/layout-sw600dp/activity_main.xmlapp/src/main/res/layout-sw720dp/activity_main.xmlapp/src/main/res/layout/activity_main.xmlgradle/wrapper/gradle-wrapper.properties
dz4va
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How to test
Ref: AJ-735
Summary by CodeRabbit
New Features
Bug Fixes