Merge/11 2/dev/2026 04 24#149
Merged
Merged
Conversation
…returnURL computation on the backend
…d-returnUrl-in-background-2 IS-9422: updates templates to support same-device and cross-device flows
…urnUrl-in-background
…-returnUrl-in-background IS-9422: adds template to evaluate browser context needed for BankID …
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the BankID authenticator UI to better support cross-device vs same-device flows (including mode switching) and introduces a small redirect template to collect browser touch capability context.
Changes:
- Preserve
flowModewhen extending QR time and add UI buttons to switch between “same-device” and “cross-device” modes. - Add a new redirect template to submit
navigator.maxTouchPoints(asnmtp) via query string. - Add new i18n strings for the new mode-switch buttons (EN, SV, PT, PT-PT).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/identity-server/templates/core/authenticator/bankid/launch/index.vm | Adds flowMode handling for the “extend” link and adds mode-switch buttons. |
| src/identity-server/templates/core/authenticator/bankid/enter-personalnumber/compute-browser-context.vm | New redirect template that submits nmtp and a ctx marker via GET. |
| src/identity-server/messages/core/sv/authenticator/bankid/launch.properties | Adds translations for new mode-switch button labels. |
| src/identity-server/messages/core/pt/authenticator/bankid/launch.properties | Adds translations for new mode-switch button labels. |
| src/identity-server/messages/core/pt-pt/authenticator/bankid/launch.properties | Adds translations for new mode-switch button labels. |
| src/identity-server/messages/core/en/authenticator/bankid/launch.properties | Adds translations for new mode-switch button labels. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luisgoncalves
approved these changes
Apr 24, 2026
urre
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.