Skip to content

IS-9818 Update .nvmrc to Node 24.19.0. - #289

Merged
renatoathaydes merged 5 commits into
devfrom
IS-9818-update-nvmrc
Aug 12, 2026
Merged

IS-9818 Update .nvmrc to Node 24.19.0.#289
renatoathaydes merged 5 commits into
devfrom
IS-9818-update-nvmrc

Conversation

@renatoathaydes

Copy link
Copy Markdown
Collaborator

Updating all projects.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 11, 2026 14:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s pinned Node.js version via .nvmrc, which is used by local development tooling (nvm) and CI (via actions/setup-node with node-version-file) to standardize the Node runtime.

Changes:

  • Bump pinned Node.js version from 22.22.0 to 24.19.0.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

renatoathaydes and others added 2 commits August 11, 2026 17:32
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@renatoathaydes

Copy link
Copy Markdown
Collaborator Author

To ALL REVIEWERS: updated the lock file and engines in the NPM file.
Hope it's done correctly.

@vahag-curity

Copy link
Copy Markdown
Contributor

@renatoathaydes Checked this one as part of the IS-9818 sweep across the five projects. The six package.json files and .nvmrc all look right, and the workflow needs no change since lwa-github-ci-workflow.yml uses node-version-file: '.nvmrc'.

Two files are left on the old pin, both documenting the prerequisite that engines now contradicts:

  • src/common/component-library/README.md lines 94-95 — Node.js >= 22.22.0, npm >= 10.9.4
  • src/identity-server/README.md lines 72-73 — same

Also worth a line in the description: this PR moves src/self-service-portal/app cypress from ^15.17.0 to an exact 15.20.0. I would keep it — it matches curity-web-ui's exact pin, and the identity-server and ssi-libs PRs do the same — but it is not forced by the node bump, so it is easy to trip over later.

Details for the other repos are on their own PRs: identity-server #10498 has a real break in check_tool_versions.sh, and curity-ssi-libs #139 still runs a node:18 pipeline.

@vahag-curity

Copy link
Copy Markdown
Contributor

@renatoathaydes Follow-up on the two READMEs above — a suggestion rather than a change request, and it applies across the whole IS-9818 sweep, so I have put the longer version on haapi-sdk-docs #8 to keep it in one place.

Short form: instead of updating src/common/component-library/README.md and src/identity-server/README.md to the new numbers, consider having them stop naming a version and point at .nvmrc / engines instead. Six doc files across the five repos restate a pin they do not enforce, and four of the five repos went stale on this bump — they will drift again next time. identity-server's .devcontainer/README.md already does it version-agnostically (nvm install vXX.YY.ZZ, plus "run nvm use to see which version").

If you would rather defer that, the two READMEs still need the numbers corrected here, otherwise they contradict the engines this PR sets.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
npm 11 no longer installs vitest's optional jsdom peer, leaving the
root-hoisted vitest unable to resolve it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@renatoathaydes
renatoathaydes merged commit 43710a2 into dev Aug 12, 2026
2 checks passed
@renatoathaydes
renatoathaydes deleted the IS-9818-update-nvmrc branch August 12, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants