mbedtls: split mbed_connect_step1 into sub functions#20689
mbedtls: split mbed_connect_step1 into sub functions#20689
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the mbedTLS TLS connection setup to improve readability by splitting mbed_connect_step1 into smaller, focused helper functions while preserving the overall connection flow.
Changes:
- Extracted CA cert, client cert, private key, CRL loading, and SSL configuration into separate helper functions.
- Reorganized
mbed_connect_step1to sequence these helpers and centralize error propagation. - Minor formatting/line-wrapping adjustments for comments and long calls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #20689 at 8edf4f78: Test ../../tests/http/test_07_upload.py::TestUpload::test_07_13_upload_seq_large[h2] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
bagder
force-pushed
the
bagder/mbed-split
branch
from
8edf4f7 to
c823c2b
Compare
|
augment review |
🤖 Augment PR SummarySummary: Refactors the mbedTLS backend’s connection setup by splitting Changes:
Technical Notes: The refactor keeps the same high-level connect state machine, but touches the ordering/propagation of return codes around session cache reuse and the optional 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
Increase readability. Reduce complexity.
bagder
force-pushed
the
bagder/mbed-split
branch
from
c823c2b to
c7e4514
Compare
🔒 Aisle Security AnalysisWe found 1 potential security issue(s) in this PR:
See details in the comment below. Analyzed PR: #20689 at commit |
![aisle-research-bot[bot]](https://avatars.githubusercontent.com/in/1901761?s=60&v=4){kind=small}
A blob must have a length or it will not be accepted. By enforcing the check here, TLS backend code can rely on the fact that the length is always non-zero from this point. Reported-by: aisle-research-bot URL: #20689 (review)
A blob must have a length or it will not be accepted. By enforcing the check here, TLS backend code can rely on the fact that the length is always non-zero from this point. Reported-by: aisle-research-bot URL: #20689 (review) Closes #20705
Increase readability. Reduce complexity.