wcurl: strip URL fragment identifier from output filename - #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for updatng
get_url_filename()to strip URL fragments (#) identically to how it strips query strings (?).Reason to do this is when someone try extracting a filename from a URL, wcurl currently strips everything after
?. however, if the URL contains a fragment.... (e.g.example.com/document.pdf#page=5), the filename is generated locally as ....document.pdf#page=5. According to RFC (Idk exact number did just AI to confirm) , the fragment identifier is client-side metadata and thus is not part of the physical file name or path.This is fixed by changing the
sedsubstitution to match[?#]instead of just?, a small regex change.Testing
Added
testFragmentStrippingtotests.shto verify#fragmentsare correctly stripped from the output filename.