fix: explose the ses email transporter so smtp isn't hardcoded - #46
Merged
Conversation
- SES has been supported from the beginning. This enables with without needing to use global.env
📝 WalkthroughWalkthroughThe chart replaces the SMTP-only email helper with ChangesEmail transport configuration
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant HelmValues
participant currents_emailEnv
participant CurrentsPod
participant AmazonSES
HelmValues->>currents_emailEnv: Select ses and set SES_REGION
currents_emailEnv->>CurrentsPod: Inject SES_TRANSPORTER and SES_REGION
CurrentsPod->>AmazonSES: Send email using IRSA credentials
AmazonSES-->>CurrentsPod: Delivery result
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/currents/templates/_common.tpl`:
- Around line 209-234: The SMTP environment-variable block must enforce required
configuration when transporter is “smtp” instead of silently omitting values.
Update the logic around the SMTP settings in the template to validate that both
$email.smtp.host and $email.smtp.secretName are provided for SMTP, failing Helm
rendering with a clear error when either is missing; preserve the existing
variable generation when both are present.
In `@docs/eks/iam.md`:
- Around line 250-257: Add the text language identifier to the fenced code block
containing the Expected output example, preserving its existing
environment-variable contents.
- Around line 241-261: The verification section currently checks only the writer
despite requiring confirmation for both email-sending Deployments. Update the
kubectl environment check to run against both currents-server and
currents-writer, preserving the existing variable filter and expected output
guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 45eb3c55-87be-4d12-9e4c-c7e333244b0d
📒 Files selected for processing (6)
charts/currents/templates/_common.tplcharts/currents/templates/server/deployment.yamlcharts/currents/templates/writer/deployment.yamlcharts/currents/values.yamldocs/configuration.mddocs/eks/iam.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation