Skip to content

fix: explose the ses email transporter so smtp isn't hardcoded - #46

Merged
twk3 merged 1 commit into
mainfrom
fix/ses-email-transporter
Aug 2, 2026
Merged

fix: explose the ses email transporter so smtp isn't hardcoded#46
twk3 merged 1 commit into
mainfrom
fix/ses-email-transporter

Conversation

@twk3

@twk3 twk3 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor
  • SES has been supported from the beginning. This enables with without needing to use global.env

Summary by CodeRabbit

  • New Features

    • Added support for sending email through Amazon SES in addition to SMTP.
    • Added configurable email transporter, sender address, and SES region settings.
    • Added SES authentication guidance using IAM roles for service accounts.
  • Bug Fixes

    • Invalid email transporter settings now produce a clear configuration error.
    • Sender address configuration now supports a fallback option.
  • Documentation

    • Updated email configuration requirements and added Amazon SES setup, verification, and troubleshooting guidance.

- SES has been supported from the beginning. This enables with without needing to use global.env
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The chart replaces the SMTP-only email helper with currents.emailEnv. It supports SMTP and SES transports, validates transport values, configures SES regions, preserves SMTP settings, and documents SES IRSA configuration and verification.

Changes

Email transport configuration

Layer / File(s) Summary
Transport configuration contract
charts/currents/values.yaml
Adds SMTP or SES selection, sender override, and SES region settings. Clarifies conditional SMTP requirements.
Transport environment rendering and deployment wiring
charts/currents/templates/_common.tpl, charts/currents/templates/server/deployment.yaml, charts/currents/templates/writer/deployment.yaml
Validates the transporter and renders transport-specific variables. Both Deployments use currents.emailEnv.
SES configuration and IRSA procedure
docs/configuration.md, docs/eks/iam.md
Documents email settings, SES IAM permissions, IRSA setup, rollout checks, and delivery verification.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant HelmValues
  participant currents_emailEnv
  participant CurrentsPod
  participant AmazonSES
  HelmValues->>currents_emailEnv: Select ses and set SES_REGION
  currents_emailEnv->>CurrentsPod: Inject SES_TRANSPORTER and SES_REGION
  CurrentsPod->>AmazonSES: Send email using IRSA credentials
  AmazonSES-->>CurrentsPod: Delivery result
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes exposing SES email transport so SMTP is not hardcoded, which matches the main change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ses-email-transporter

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@charts/currents/templates/_common.tpl`:
- Around line 209-234: The SMTP environment-variable block must enforce required
configuration when transporter is “smtp” instead of silently omitting values.
Update the logic around the SMTP settings in the template to validate that both
$email.smtp.host and $email.smtp.secretName are provided for SMTP, failing Helm
rendering with a clear error when either is missing; preserve the existing
variable generation when both are present.

In `@docs/eks/iam.md`:
- Around line 250-257: Add the text language identifier to the fenced code block
containing the Expected output example, preserving its existing
environment-variable contents.
- Around line 241-261: The verification section currently checks only the writer
despite requiring confirmation for both email-sending Deployments. Update the
kubectl environment check to run against both currents-server and
currents-writer, preserving the existing variable filter and expected output
guidance.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 45eb3c55-87be-4d12-9e4c-c7e333244b0d

📥 Commits

Reviewing files that changed from the base of the PR and between 91f17d5 and 8fc14ac.

📒 Files selected for processing (6)
  • charts/currents/templates/_common.tpl
  • charts/currents/templates/server/deployment.yaml
  • charts/currents/templates/writer/deployment.yaml
  • charts/currents/values.yaml
  • docs/configuration.md
  • docs/eks/iam.md

Comment thread charts/currents/templates/_common.tpl
Comment thread docs/eks/iam.md
Comment thread docs/eks/iam.md
@twk3 twk3 changed the title fix: explose the ses email transporter do smtp isn't hardcoded fix: explose the ses email transporter so smtp isn't hardcoded Aug 2, 2026
@twk3
twk3 merged commit cd03b76 into main Aug 2, 2026
3 checks passed
@twk3
twk3 deleted the fix/ses-email-transporter branch August 2, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant