fix: add-company modal not closing after successful save#397
Closed
Lp-Francois wants to merge 0 commit into
Closed
fix: add-company modal not closing after successful save#397Lp-Francois wants to merge 0 commit into
Lp-Francois wants to merge 0 commit into
Conversation
|
@Lp-Francois is attempting to deploy a commit to the Anysphere Team on Vercel. A member of the Team first needs to authorize it. |
ec74ea4 to
8108ed5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
reload=trueCompanyFormto update bothreloadandaddCompany(addCompanycontrols the modal)Why
When creating a company from
/companies?addCompany=true, the modal stayed open after a successful save becauseaddCompanywas never reset tofalse. This leads people to think the save didn't happen.Testing
bun run typecheck(fromapps/cursor)Note
Low Risk
Small query-param and modal state fix on the companies form with no auth or data-layer changes.
Overview
Fixes the Add Company modal staying open after a successful save when opened via
/companies?addCompany=true.On success,
CompanyFormnow clears theaddCompanyquery flag (which drives the modal) while still settingreload=trueso the companies list refreshes without a full redirect. Previously only reload was updated, so users often saved again and created duplicate companies.Reviewed by Cursor Bugbot for commit 8108ed5. Bugbot is set up for automated code reviews on this repo. Configure here.