pstack: cut model-config prose to its definition sites#167
Merged
Conversation
Keep the inherit-parent/auto definition in setup-pstack (steps 1/3/4 and the generated rule's header comment) and one poteto-mode clause; drop the per-call-site resolution instructions from how, why, arena, architect, reflect, and interrogate, restoring the compact configured-role pointers with the current defaults. Make interrogate reviewer counts configurable: the interrogate reviewers list sets the panel size and the Reviewer A/B/C labels extend or shrink to the entry count. Bump 0.11.7 -> 0.11.8.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Interrogate drops alias spawn guard
- Restored the instruction to omit
modelfor alias entries and exclude those aliases from slug fallback handling.
- Restored the instruction to omit
Or push these changes by commenting:
@cursor push 86e3420fe6
Preview (86e3420fe6)
diff --git a/pstack/skills/interrogate/SKILL.md b/pstack/skills/interrogate/SKILL.md
--- a/pstack/skills/interrogate/SKILL.md
+++ b/pstack/skills/interrogate/SKILL.md
@@ -43,10 +43,10 @@
For each reviewer:
- `subagent_type`: `generalPurpose`
-- `model`: the configured `interrogate reviewers` entry, or the table default with no configured line
+- `model`: the configured `interrogate reviewers` entry, or the table default with no configured line; omit `model` for `inherit-parent` or `auto`
- `readonly`: `true`
-If a model slug is rejected as unresolvable when you try to spawn the subagent, check the valid slugs in the Task tool's error message, pick the closest equivalent (prefer the highest-reasoning tier of the same family), spawn with the valid slug, and open a separate PR to update the configured value or default table. Do not block the review on the slug issue.
+If a real model slug is rejected as unresolvable when you try to spawn the subagent, check the valid slugs in the Task tool's error message, pick the closest equivalent (prefer the highest-reasoning tier of the same family), spawn with the valid slug, and open a separate PR to update the configured value or default table. Do not block the review on the slug issue. Never treat `inherit-parent` or `auto` as model slugs or enter this fallback for them.
Read `references/reviewer-prompt.md` and fill in the template with:
1. The stated intentYou can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit f3fc065. Configure here.
Co-authored-by: lauren <poteto@users.noreply.github.com>
poteto
marked this pull request as ready for review
July 23, 2026 22:11
github-actions Bot
added a commit
to SmailG/claude-cursor-plugins
that referenced
this pull request
Jul 24, 2026
…ts definition sites (cursor#167) chore: sync with cursor/plugins — pstack: cut model-config prose to its definition sites (cursor#167)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Model routing behavior is unchanged; the prose shrinks to the places that define it.
setup-pstackkeeps theinherit-parent/autodefinition (steps 1, 3, 4) and writes it into the generated rule's header comment; the five-line resolution block collapses to one definition line.poteto-modekeeps one alias clause at the end of the Task-call defaults paragraph.how,why,arena,architect,reflect, andinterrogatedrop their per-call-site resolution instructions ("pass a real slug / omitmodelforinherit-parent/auto/ if the role line is absent...") and return to compact configured-role pointers. All current model defaults stay exactly as they are.interrogategains configurable reviewer counts: theinterrogate reviewerslist sets the panel size, the Reviewer A/B/C labels extend or shrink to the configured entry count, and a default table keeps the current panel.Why
Call-mechanics instructions in skill prose do not change agent behavior; the subagent tool schema (model optional, omitted inherits the parent) governs. Prose that defines what a config value means is what earns its place. Verified with blinded behavioral runs on this tree: a mixed config planted (aliases on panel roles, real slugs elsewhere, one role line deleted), multiple parent model families, spawn calls graded mechanically from transcripts. One blinded run showed a config-misread unrelated to this change (that agent never opened the skill file this change edits for that path); the fan-out and alias invariants held across all runs.
Version
0.11.7 -> 0.11.8 (skill-content change, per repo convention).