Skip to content

Conversation

@aalavender
Copy link
Contributor

it's disabled when show_topn > number of rss entries

return False
else:
self._state = len(parsedFeed.entries)
#self._state = len(parsedFeed.entries)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and remove thid

self._entries = []

for entry in parsedFeed.entries:
#for entry in parsedFeed.entries:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too

Copy link
Member

@iantrich iantrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could remove those commented out lines, I’ll merge this

@aalavender aalavender closed this Jul 31, 2019
@aalavender aalavender reopened this Jul 31, 2019
@aalavender aalavender changed the title Add a Configuration variables "show_topn", Add "show_topn" and try find image from summary filed Jul 31, 2019
@aalavender
Copy link
Contributor Author

aalavender commented Jul 31, 2019

i removed commented out lines and i add a new function:
when inclusions contains image option, it will try to find image within
summary filed if image not found

can you see the changes?

@iantrich iantrich merged commit 675378d into custom-components:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants