Added support for ware 2nd gen. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartyTremblay
left a comment
MartyTremblay
left a comment
There was a problem hiding this comment.
This looks good!
I can't test it but I'm confidant that it will work as expected.
| def decode_data(self, raw_data): | ||
| val = super().decode_data(raw_data) | ||
| val = val[self.name] | ||
| # if val[0] != 1: |
Member
There was a problem hiding this comment.
Just being a stickler here. Should this dead code be removed? Any reason to keep it in a comment?
Contributor
Author
There was a problem hiding this comment.
Yes it can be removed, i just forgot.
Contributor
Author
|
I have verified it on my airthings wave 2. The uuid i got from airthigs example: |
MartyTremblay
approved these changes
Aug 26, 2020
Member
|
Added support for ware 2nd gen |
Member
|
resolves #23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is support for The Airthings Wave 2nd generation. This new version or the airthings wave has a new uuid, but returns data the same way as the wave plus (but only a subset)