added escape clause to while loop to eliminate retries after successfull connection: Closes #50 in my case #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomTorger
changed the title
TomTorger
changed the title
TomTorger
changed the title
TomTorger
changed the title
Contributor
Author
|
Tried to link it to issue #50 , seems likely they are suffering from the same behavior. |
Collaborator
|
Nice catch, looks right to me, I guess I can merge it but best if @MartyTremblay would merge it and do a release if he is happy. |
Member
|
I've been chronically neglectful this project so my apologies for not being more responsive. Merging now, @sverrham, feel free to merge going forward. This is as much yours than mine ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The while loop will continue to create the Peripheral object, even if successful on the first go. On a nuc, this causes exceptions and ultimately a failure to connect.