fix: Drain all buffered hops per PhaseVocoder.process() call - #88
Open
bhj wants to merge 1 commit into
Open
Conversation
PhaseVocoder.process() handled at most one analysis hop per call, unlike the WSOLA Stretch stage, which loops until its input holds less than one hop. Callers that feed fixed-size blocks and call process() once per block — the worklet processors feed 128-frame render quanta — starve whenever a block spans more than one hop: at hop 64 (fftSize 512 / overlap 8) output ran at roughly half speed with every block underrunning, and at hop 128 (512/4, 1024/8) down-shifts starved the same way once the transposer's expansion pushed a block's worth of input past one hop. process() now drains every whole buffered hop per call, matching the Stretch contract. Measured at the previously broken configurations: unity-pitch correlation against the input recovers from ~0.04 to 1.0 with zero underruns, and down-shift underruns collapse from every block to the normal knife-edge residual. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one seems pretty straightforward. Related to #87
Model used: Anthropic Fable 5