ci: rename the Verify workflow to Gates - #34
Merged
Conversation
The reusable quality-gate workflow runs `bun run gates`, but was still named `verify` (file, workflow name, and caller job ids) — a leftover from before the runner was renamed verify-json.ts -> gates.ts. Rename verify.yml -> gates.yml, `name: Verify` -> `name: Gates`, and the caller jobs in pr/main/release from `verify` -> `gates` (with matching `needs:`), so CI naming matches the command it runs. No behavior change. Note: the local `bun run verify` script (the human, sequential gate chain) is left as-is — it's distinct from `bun run gates` (the parallel JSON runner) and can't share that name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reusable quality-gate workflow runs
bun run gates, but was still namedverify— the file (verify.yml), thename: Verify, and the caller job ids. That's a leftover from before the runner was renamedverify-json.ts→gates.ts. This renames the CI naming to match the command it runs.Changes (workflow files only)
verify.yml→gates.yml(git-detected rename; history preserved)name: Verify→name: Gates, header comment now referencesbun run gatesverify:→gates:,name: Verify→name: Gates,uses: …/verify.yml→…/gates.yml, andneeds: [verify]→needs: [gates](incl. release's[guard, gates])2. verify→2. gatesNo behavior change — the reusable job still runs the exact same
bun run gates. All four workflow YAMLs validated.Left intentionally unchanged
The local
bun run verifyscript (the human, sequential gate chain) stays — it's distinct frombun run gates(the parallel JSON runner) and can't share that name. README/CONTRIBUTING/docs reference that local script, not the workflow, so they're untouched.If
mainhas a required status check named likeVerify / Quality gates, this rename changes the reported check toGates / Quality gates— the old required check would never report and could block merges. If so, update the required-check name in Settings → Branches (and this PR may need its own required check updated to merge).