Skip to content

Better reload/reset table#5900

Merged
omichel merged 10 commits intoreleasedfrom
fix-make-table-easier-to-read
Feb 15, 2023
Merged

Better reload/reset table#5900
omichel merged 10 commits intoreleasedfrom
fix-make-table-easier-to-read

Conversation

@omichel
Copy link
Copy Markdown
Member

@omichel omichel commented Feb 15, 2023

This PR tries to make the supervisor reload/reset/etc. table easier to read:
https://cyberbotics.com/doc/reference/supervisor?version=fix-make-table-easier-to-read

@omichel omichel added the documentation Improve or fix the documentation (MD files only, no software development) label Feb 15, 2023
@omichel omichel self-assigned this Feb 15, 2023
@omichel omichel marked this pull request as ready for review February 15, 2023 11:01
@omichel omichel requested a review from a team as a code owner February 15, 2023 11:01
BenjaminDeleze
BenjaminDeleze previously approved these changes Feb 15, 2023
Copy link
Copy Markdown

@BenjaminDeleze BenjaminDeleze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not totally convinced that the changes improve the readability but they are correct.

@omichel
Copy link
Copy Markdown
Member Author

omichel commented Feb 15, 2023

I am not totally convinced that the changes improve the readability but they are correct.

If they don't improve readability, we should not merge this PR.

@omichel
Copy link
Copy Markdown
Member Author

omichel commented Feb 15, 2023

@ygoumaz, @ad-daniel and @stefaniapedrazzi: what do you think?

@ygoumaz
Copy link
Copy Markdown
Contributor

ygoumaz commented Feb 15, 2023

Maybe centering the text in merged cells may look better, but hard to tell without trying.

@omichel
Copy link
Copy Markdown
Member Author

omichel commented Feb 15, 2023

Maybe centering the text in merged cells may look better, but hard to tell without trying.

Done.

@ygoumaz
Copy link
Copy Markdown
Contributor

ygoumaz commented Feb 15, 2023

It is indeed better imo.

@stefaniapedrazzi
Copy link
Copy Markdown
Member

I'm not sure either that the readability is better than before.
I have the feeling that it is even more difficult to understand what is the title of the column by merging all these cells.
I find it easier in the previous version to understand the meaning of the 6 columns.

@stefaniapedrazzi
Copy link
Copy Markdown
Member

If it would be possible to add some borders between columns in the header row, then probably it will be much better.

@omichel omichel changed the title Update supervisor.md Better reload/reset table Feb 15, 2023
@omichel
Copy link
Copy Markdown
Member Author

omichel commented Feb 15, 2023

I just added header columns, vertical centering and colors... Is that better?

@stefaniapedrazzi
Copy link
Copy Markdown
Member

Yes, I think it is better like this.

@omichel omichel merged commit 793a6e2 into released Feb 15, 2023
@omichel omichel deleted the fix-make-table-easier-to-read branch February 15, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improve or fix the documentation (MD files only, no software development)

Development

Successfully merging this pull request may close these issues.

4 participants