Skip to content

Fix smile of MyBot robot#5989

Merged
stefaniapedrazzi merged 2 commits intomasterfrom
hotfix-mybot-appearance
Mar 14, 2023
Merged

Fix smile of MyBot robot#5989
stefaniapedrazzi merged 2 commits intomasterfrom
hotfix-mybot-appearance

Conversation

@stefaniapedrazzi
Copy link
Copy Markdown
Member

@stefaniapedrazzi stefaniapedrazzi commented Mar 14, 2023 •
edited
Loading

Fix smile of MyBot robot:

  • accelerometer.wbt: cylinder orientation is wrong and smile is hidden inside the body
  • camera_recognition.wbt: smile is displayed on the back of the robot
  • fix the smile when using a textured IFS

@stefaniapedrazzi stefaniapedrazzi added the enhancement Implementation of a minor feature label Mar 14, 2023
@stefaniapedrazzi stefaniapedrazzi added this to the R2023a-rev1 milestone Mar 14, 2023
@stefaniapedrazzi stefaniapedrazzi requested a review from a team as a code owner March 14, 2023 09:39
@stefaniapedrazzi stefaniapedrazzi self-assigned this Mar 14, 2023
@ad-daniel ad-daniel requested a review from omichel March 14, 2023 09:43
@omichel
Copy link
Copy Markdown
Member

omichel commented Mar 14, 2023

Thank you. The one on the camera_recognition still looks wrong:
camera_recognition_2
camera_recognition
camera_recognition_1

@stefaniapedrazzi
Copy link
Copy Markdown
Member Author

stefaniapedrazzi commented Mar 14, 2023

I restored the status before the ENU conversion.
But you are right, it is still wrong.
I will also fix all the other instances using this smile.

@omichel
Copy link
Copy Markdown
Member

omichel commented Mar 14, 2023

If simpler, you can also use the one of accelerometer.wbt which is fine.

@stefaniapedrazzi
Copy link
Copy Markdown
Member Author

stefaniapedrazzi commented Mar 14, 2023

I adjusted the coordinates of the IFS and now the smile is completely visible.

omichel
omichel approved these changes Mar 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@stefaniapedrazzi stefaniapedrazzi merged commit f03b403 into master Mar 14, 2023
@stefaniapedrazzi stefaniapedrazzi deleted the hotfix-mybot-appearance branch March 14, 2023 11:17
omichel pushed a commit that referenced this pull request Mar 15, 2023
@github-actions @stefaniapedrazzi
Fix smile of MyBot robot (#5989) (#5993)
ac01595 
* Fix smile of MyBot robot

* Fix MyBot smile IFS

Co-authored-by: Stefania Pedrazzi <stefaniapedrazzi@users.noreply.github.com>
Co-authored-by: Benjamin Délèze <benjamin.deleze@cyberbotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omichel omichel omichel approved these changes

Assignees

@stefaniapedrazzi stefaniapedrazzi

Labels

enhancement Implementation of a minor feature

Milestone

R2023a-rev1

Development

Successfully merging this pull request may close these issues.

2 participants

@stefaniapedrazzi @omichel