Fix webotsjs type in parser#5995
Merged
BenjaminDeleze merged 1 commit intofix-webjs-bounding-spherefrom Mar 15, 2023
Merged
Conversation
stefaniapedrazzi
added a commit
that referenced
this pull request
Mar 15, 2023
* Port bounding sphere fix to webotsjs * Fix boundingSphere * Fix CadShape bounding sphere * Remove unused radius * Update resources/web/wwi/nodes/WbDevice.js Co-authored-by: Benjamin Délèze <benjamin.deleze@cyberbotics.com> * Fix type in parser (#5995) --------- Co-authored-by: Benjamin Délèze <benjamin.deleze@cyberbotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some floats/int were passed as string.
It was undetected until now because in most operation JS succeed to use string instead of number, for example:
But it results in some
NaNin #5985