Adopt restyled gestures in Command Universe - #5320
Merged
Merged
Conversation
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 9, 2026 02:40
6ef52bd to
f76b1bb
Compare
This was referenced Sep 9, 2026
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 9, 2026 03:37
f76b1bb to
898e355
Compare
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 9, 2026 04:59
898e355 to
1dde3cf
Compare
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 9, 2026 05:28
1dde3cf to
4320d67
Compare
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 9, 2026 05:42
4320d67 to
4a97fb5
Compare
fbmcipher
marked this pull request as ready for review
September 9, 2026 05:55
raineorshine
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 9, 2026 18:41
4a97fb5 to
abf92d6
Compare
raineorshine
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 9, 2026 19:02
abf92d6 to
f384146
Compare
raineorshine
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 9, 2026 19:23
f384146 to
7ec99a6
Compare
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 10, 2026 02:10
c153664 to
b7c76bc
Compare
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 10, 2026 03:40
b7c76bc to
6f463b9
Compare
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 10, 2026 03:50
6f463b9 to
44e0429
Compare
This was referenced Sep 10, 2026
fbmcipher
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 11, 2026 04:52
44e0429 to
3752610
Compare
Base automatically changed from
fbmcipher/issue-4186-responsive-framing
to
main
September 11, 2026 18:02
Add the Command Universe gradient tokens, select the established GestureDiagram presentation and container options, and cover the three geometry families plus responsive framing in the visual fixture. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
Opt the grid into normalized curved geometry and centered square framing without changing default diagram callers. Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Select the production sizing policy in all four new examples and update the reviewed snapshot. Legacy examples retain their original dimensions. Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Remove the uniform sizing option from the production grid and visual examples now that sizing is consistent for every caller. Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Record the reviewed shared sizing and framing behavior in the four CU presentation examples. Co-Authored-By: Codex GPT-6 <noreply@openai.com>
raineorshine
force-pushed
the
fbmcipher/issue-4186-command-universe
branch
from
September 11, 2026 18:02
3752610 to
a4da49a
Compare
raineorshine
approved these changes
Sep 11, 2026
The yarn 4.18.0 upgrade changed the hash of the builtin compat/resolve patch, so `yarn install --immutable` in CI wanted to rewrite the lockfile and every job failed at the install step. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
raineorshine
added a commit
that referenced
this pull request
Sep 11, 2026
A pull request stacked on another's branch contains every commit of its
base, so GET /commits/{sha}/pulls lists both. Preview QR refused to pick
one and left the base pull request's description stuck at "Generating new
QR code…" for a commit it had already force-pushed away (#5319, stacked
under #5320). Select the pull request whose current head is the commit
instead; only two pull requests sharing a head commit are still ambiguous.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
raineorshine
added a commit
that referenced
this pull request
Sep 11, 2026
…5526) A pull request stacked on another's branch contains every commit of its base, so GET /commits/{sha}/pulls lists both. Preview QR refused to pick one and left the base pull request's description stuck at "Generating new QR code…" for a commit it had already force-pushed away (#5319, stacked under #5320). Select the pull request whose current head is the commit instead; only two pull requests sharing a head commit are still ambiguous. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4186
Apply the new gesture appearance to the mobile Command Universe using the API from #5315–#5319. Based on #5319; this is the final PR in the stack.
CommandUniverseGridItemconfiguresGestureDiagramthrough props. It adds no geometry or SVG rendering code. Other callers retain their current renderer, including solid binary highlighting in the Gesture Menu.Appearance changes
width: 100%, capped at 130px.#58b5d4at 45% alpha to white. The newgestureDiagramGradientStartandgestureDiagramGradientEndtokens are identical in both palettes because the dialog uses fixed dark background art.size={150},strokeWidth={12},cornerRadius={12}, andarrowhead='outlined-wide'. Disable the glow withglow={false}. Geometry sizing and framing use the shared behavior from Fix inconsistent gesture sizing and stroke thickness #5319. Ordinary block styling lets the SVG fit the parent.command.rounded, so gestures such asnewThoughtAboveandtoggleSortuse circular geometry in the grid, where that flag was previously omitted.arrowSize={1}; framing reserves room for the geometry-based wide chevron, whilerdldremains arrowhead-free.Validation and visual review
Four examples of the CU presentation are added to
TestGestureDiagram: softened straight geometry, a circular gesture,rdld, and a diagram filling its container. This PR updates the gesture-diagram snapshot for those examples. Earlier fixture definitions and other snapshot files are unchanged.The stack includes direct geometry and static-rendering tests, plus the existing Gesture Menu and Puppeteer coverage. Review the mobile Command Universe at narrow and wide widths: compare gesture size, gradients, corner joins, circular gestures, chevrons, and clipping. Check the Gesture Menu's partial highlighting separately to confirm its binary treatment remains intact.
Circular gestures inherit #5318's tangent connection to the chevron, keeping the shaft connected and the gradient continuous through the tip. Cancel-gesture styling and conventional marker shapes are outside this PR.
Preview Deployment · Sep 11, 2026, 6:10 PM UTC · 21f94ee