Conversation
Using default values for all checks, enabled 15 additional checks.
…ypes Created function to check for compatible media types. Shortened line lengths when implemented.
Refactored to use string interpolation in several places within `yargs` invocation. Shortened line lengths when implemented. Removed unneeded quotes from configuration object fields.
Increase to the number of required newlines after class definitions (3).
…ts-test.coffee,hooks-test.coffe
Added ability to dump individual test results. Each test now in function invoked from `before()` method. Converted tests to use `expect()`. Reworded some test descriptions. Changed Express app response method to `.json()` shortening each test by two lines. Replaced existing "--timeout" test as it didn't actually check whether Mocha stopped the test due to timeout occurring.
Added `markdownlint` and configured it as a Grunt task.
Whoops. Forgot to add markdownlint config file with last commit.
Added package that checks for 'use strict' within CoffeeScript source. Configured coffeelint to add the rule.
Added 'use strict' to (almost) all functions within codebase. Couple warnings remain. CLI coming refactor will eliminate two more.
Broke test into two, testing for acceptability based on header value. The latter now triggers HTTP 406 failure. Additional minor description changes elsewhere.
Added 'use strict' to eliminate warnings. Added JSON error reporting. Modified port handling and reporting.
Added 'use strict' to hookfile function.
Replaced various empty function calls with named `noop()` function.
Added Accept-specific context and migrated existing tests there.
…s-test.coffee,README.md): Renam Renamed RAML files as appropriate. Updated affected tests and README.
Added newlines where needed to better separate where tests begin/end. [ci skip]
Previous commit for renaming RAML files accidentally included untested modifications. Broken parts have been corrected or removed.
… tests `.catch` blocks were added to all tests to ensure Mocha can detect test completion.
…tests Last two tests were not verifying callback was called and test was added.
…orters` Existing code was literally copied from Mocha. Now instead of pretending to be Mocha, we tell Mocha to handle it. Little more awkward than hoped as option is handled within script rather than by its module export.
Almost a style change (but involved code). Reformatted option descriptions to fit within 80 chars. Additionally, removed the variable and just exported the object itself.
Removed spaces between response directives. Additionally, corrected misspelled 'cacheing'.
…sponse Original code applied only to HTTP/1.1. Added two additional headers to handle HTTP/1.0, as well as proxies.
…sable HTTP caching in response Added two additional headers to the stub code, missed in last commit. Made the e2e test match the stub's implementation.
Add entries to eliminate unneded files in package artifact upon publication. [ci skip]
Add entries to prevent undesired files from being added to SCCS. [ci ckip]
Create main() to export from CLI. Code now executes main() function, with CLI options passed from binary.
When resetting test objects, use `undefined` rather than empty string. Ensured test creation always performed in `before(done)`. Swapped order of restores in a couple `after` calls.
Had added everything for "commitizen" package some time back (except itself **face palm**). Added "husky" package, which provides Git pre-hooks, allowing *forced* test prior to commit. Changed "yargs" option to its actual value. Bumped package version (which should have been done a while back).
…function Refactored a test creation function, now called by each test. Additionally, ensured reused variables would be reset to `undefined`.
….coffee): Rename 'apply-configu Preparing to change how configuration will work going forward. Renamed file itself, and in the abao `require`. Removed from test code as unused.
Eliminated unnecessary export of cmdline options.
…grate all configuration into si Completed first phase of getting all configuration into single file.
Corrected variable name.
…fee,lib/configuration.coffee): Split options according to who used them. This should complete second phase of three for configuration.
Last commit renamed the file, but left out changes to remove Mocha options.
Debug why `npm publish` has not been occurring.
Added missing 'use strict' to `asConfiguration()`.
Simplified understanding waterfall steps. Added error handling to loading RAML step. Noted shortcoming in current `addHooks()` handling.
…ffee): Revamp `addHooks()` to u Significant rewrite with more error checking. Updated associated tests and invocation.
Removed unnecessary parentheses.
Collaborator
Author
|
@cybertk Please fix this and the web hooks ! You're not responding for weeks at a time, if at all... https://travis-ci.org/cybertk/abao/jobs/365151930 Deploying application
NPM API key format changed recently. If your deployment fails, check your API key in ~/.npmrc.
http://docs.travis-ci.com/user/deployment/npm/
~/.npmrc size: 48
npm ERR! publish Failed PUT 401
npm ERR! code E401
npm ERR! 404 You must be logged in to publish packages. : abao
npm ERR! 404
npm ERR! 404 'abao' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/travis/.npm/_logs/2018-04-11T14_37_48_513Z-debug.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot more code cleanup. More improvements to the E2E test as well as other unit tests (e.g., custom headers, HEAD/OPTIONS methods). Linting of code/documentation much stricter than before. RAML test fixtures were all renamed to include the name of the service being tested. Various README updates. Minor updates to .gitignore/.npmignore. Reimplemented code handling
--reportersoption. Options handling/configuration heavily modified (more coming). Hook file loading rewritten.Added support for "commitizen" and "husky" packages.
Fixes
Removed
banUnknownproperty from tv4 exported module (#237).