chore: enforce the 24h supply-chain soak - #188
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 9 9
Lines 118 118
Branches 44 44
=======================================
Hits 117 117
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pnpm-workspace.yaml carried no minimumReleaseAge, so nothing held back a freshly-published version of any dependency, direct or transitive. This is the fleet-standard 24h window, matching the ~30 repos that already have it. The window did exist in .npmrc as `minimumreleaseage`, which is not a valid npm or pnpm key: it never reaches pnpm's typed config, so `pnpm config get minimumReleaseAge` returned undefined and no version was ever held back. That line is removed rather than corrected - leaving a second, non-functional home for the setting is what hid the problem. minimumReleaseAgeStrict is set alongside it. Without it pnpm runs LOOSE: a too-young package is not rejected, it is appended to minimumReleaseAgeExclude and installed anyway, so the soak excuses itself on every install. No exclusion list is added; the install resolves cleanly under the gate. Verified: pnpm config get minimumReleaseAge reads 1440 and minimumReleaseAgeStrict true, and pnpm install --frozen-lockfile resolves with no lockfile change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ETjy9oQGyETyFmDBdR9Egz
unional
force-pushed
the
chore/enforce-supply-chain-soak
branch
from
September 5, 2026 21:04
a063386 to
6da3c4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the fleet-wide dead-control audit, which checked all 74 pnpm-workspace repos across
unional,cyberuni,repobuddyandjustland. This repo had nominimumReleaseAgeat all, so nothing held back a freshly-published version of any dependency, direct or transitive.This is not a new policy —
minimumReleaseAge: 1440is what ~30 repos in the fleet already carry. This one was simply missing it.The window existed, in the one place it does nothing
.npmrccarriedminimumreleaseage. That is not a valid npm or pnpm key — it never reaches pnpm's typed config, sopnpm config get minimumReleaseAgereturnedundefinedand no version was ever held back. The line is removed rather than corrected: leaving a second, non-functional home for the setting is what hid this in the first place.Both settings, because one without the other does nothing
minimumReleaseAgeStrictis set alongside the window. Without it pnpm runs loose: a too-young package is not rejected, it is appended tominimumReleaseAgeExcludeand installed anyway — so the soak excuses itself on every install and the waiver list grows without anyone deciding to add to it.No exclusion list is added. The install resolves cleanly under the gate.
Verified
🤖 Generated with Claude Code
https://claude.ai/code/session_01ETjy9oQGyETyFmDBdR9Egz